Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.9] WINC-818: [test] Fix upgradeable condition test #1347

Merged
merged 2 commits into from
Jan 13, 2023
Merged

[release-4.9] WINC-818: [test] Fix upgradeable condition test #1347

merged 2 commits into from
Jan 13, 2023

Conversation

saifshaikh48
Copy link
Contributor

This is a manual cherry-pick of #1339

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 30, 2022 •
edited

@saifshaikh48: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.9] WINC-818: [test] Fix upgradeable condition test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saifshaikh48
Copy link
Contributor Author

Might be running into kubernetes-sigs/controller-tools#643
@mansikulkarni96 PTAL when you have time

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aravindhp, saifshaikh48

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2022
@aravindhp
Copy link
Contributor

/lgtm
/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a3962d6 and 2 for PR HEAD 7c90206 in total

@aravindhp
Copy link
Contributor

/hold

 [1/2] STEP 47/47: RUN make build
go fmt ./...
go vet ./...
# sigs.k8s.io/json/internal/golang/encoding/json
vendor/sigs.k8s.io/json/internal/golang/encoding/json/encode.go:1249:12: sf.IsExported undefined (type reflect.StructField has no field or method IsExported)
vendor/sigs.k8s.io/json/internal/golang/encoding/json/encode.go:1255:18: sf.IsExported undefined (type reflect.StructField has no field or method IsExported)

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 15, 2022
@mtnbikenc
Copy link
Member

@saifshaikh48 Please update this PR when you have a chance.

mansikulkarni96 and others added 2 commits January 12, 2023 14:32
@mansikulkarni96 @saifshaikh48
[test] Fix upgradeable condition test
ddc5aee 
This commit fixes an issue where the upgradeable condition was
not being tested in the e2e test suite. This was the case
because the OPERATOR_CONDITION_NAME env var is not being set in
the CI env when using the OLM upgrade workflow. The recommendation
to fix this was to instead get it from the deployment spec as the
condition is present once the operator is deployed. The cache
client had to be replaced with the OLM client to get the operator
condition using current context.

(cherry picked from commit 0ffe33d)
(cherry picked from commit cee94c5)
(cherry picked from commit d64297a)
@saifshaikh48
[vendor] Vendor dependencies for OLM clientset
a2a4a87 
Ran with go v1.16:
- `go get github.com/operator-framework/operator-lifecycle-manager/pkg/api/client/clientset/versioned@v0.19.1`
- `go mod tidy && go mod vendor`
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2023
@saifshaikh48
Copy link
Contributor Author

updated to import a go1.16 compatible version of the client library

@mtnbikenc
Copy link
Member

Build issue resolved.
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2023
@aravindhp
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4f5adba and 2 for PR HEAD a2a4a87 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2023

@saifshaikh48: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 5ad7252 into openshift:release-4.9 Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aravindhp aravindhp aravindhp approved these changes

@mansikulkarni96 mansikulkarni96 Awaiting requested review from mansikulkarni96

@sebsoto sebsoto Awaiting requested review from sebsoto

Assignees

@aravindhp aravindhp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@saifshaikh48 @aravindhp @openshift-ci-robot @mtnbikenc @openshift-merge-robot @mansikulkarni96