Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upload-ami: Extend blurb about how things should go into coreos-assembler #690

Merged
merged 1 commit into from Jan 4, 2022
Merged

upload-ami: Extend blurb about how things should go into coreos-assembler #690

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 7 additions & 2 deletions scripts/upload-ami
View file
Open in desktop
@@ -1,8 +1,13 @@
#!/usr/bin/python3 -u

# Wraps coreos-assembler buildextend-aws which itself wraps `ore aws upload`,
# THIS SCRIPT SHOULD BE CONSIDERED DEPRECATED; please avoid extending it!
# Instead, add new functionality into coreos-assembler.
#
# This wraps coreos-assembler buildextend-aws which itself wraps `ore aws upload`,
# but also supports making the images public because ore doesn't do that right
# now. Eventually we may use plume?
# now. For FCOS, that's handled via plume, but RHCOS as of right now doesn't
# use that. But, what would make sense here is to move some of this functionality
# into cosa buildextend-aws, such as the marketplace support.

import argparse
import json
Expand Down