upload-ami: Extend blurb about how things should go into coreos-assembler #690
Conversation
…bler Motivated by recent Aliyun additions; adding stuff like that here makes it harder to do Aliyun stuff with FCOS *and* breaks the model that this repo is the definition of the OS, not the pipeline to build the OS.
openshift-ci
bot
added
the
approved
|
The other big thing we actually should do I think is only make AMIs or equivalent public at the time we go to bump the installer bootimage. That would drop the need for "make things public" logic in this script and the RHCOS pipeline by default. (And a "make all the AMIs public" logic could go in coreos-assembler too, factored out from plume if it's doing that) |
|
@cgwalters: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm Folding this whole script into cosa could be a nice project for someone wanting to get familiar with it. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Motivated by recent Aliyun additions; adding stuff like that here
makes it harder to do Aliyun stuff with FCOS and breaks the model
that this repo is the definition of the OS, not the pipeline to
build the OS.