Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WMCO-2.0.2: Added a release note to the WMCO 2.0.2 release #34370

Merged

Conversation

EricPonvelle
Copy link
Contributor

@EricPonvelle EricPonvelle commented Jul 7, 2021

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 7, 2021
@netlify
Copy link

netlify bot commented Jul 7, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: c5bdaa5

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/60e74d6d691254000893e99c

😎 Browse the preview: https://deploy-preview-34370--osdocs.netlify.app/openshift-enterprise/latest/windows_containers/windows-containers-release-notes-2-x

@EricPonvelle EricPonvelle force-pushed the WMCO2.0.2-ReleaseNotes branch 2 times, most recently from ece1633 to 4efc9ce Compare July 7, 2021 14:28
@EricPonvelle EricPonvelle force-pushed the WMCO2.0.2-ReleaseNotes branch 3 times, most recently from 6f665ae to 527911e Compare July 7, 2021 18:11
Copy link
Contributor

@mikemckiernan mikemckiernan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits. Let me know if I can clarify or help in any way.

@EricPonvelle EricPonvelle force-pushed the WMCO2.0.2-ReleaseNotes branch 2 times, most recently from adb0030 to e05fc93 Compare July 7, 2021 19:15
@EricPonvelle EricPonvelle force-pushed the WMCO2.0.2-ReleaseNotes branch 3 times, most recently from 61fd2b5 to 04909a5 Compare July 8, 2021 13:47
Copy link

@aravindhp aravindhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2021
@bmcelvee
Copy link
Contributor

bmcelvee commented Jul 8, 2021

Couple of suggestions, otherwise LGTM!

@bmcelvee bmcelvee added peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.7 branch/enterprise-4.8 labels Jul 8, 2021
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 8, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 8, 2021
@sjstout
Copy link
Contributor

sjstout commented Jul 8, 2021

lgtm. You can go ahead and merge, especially since this if for the WINC 2.0.2 release, which went out today.

@bmcelvee bmcelvee added this to the Next Release milestone Jul 8, 2021
@bmcelvee bmcelvee merged commit c8beb25 into openshift:enterprise-4.7 Jul 8, 2021
@EricPonvelle EricPonvelle deleted the WMCO2.0.2-ReleaseNotes branch July 9, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.7 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants