Ibmcloud e2e #636

Mathieu-Ferraton · 2022-04-13T14:28:02Z

No description provided.

openshift-ci · 2022-04-13T14:29:36Z

Hi @Mathieu-Ferraton. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kaovilai · 2022-04-14T03:45:12Z

/ok-to-test

improve test filtering and add labels to aws specific test cases

Mathieu-Ferraton · 2022-05-03T15:17:46Z

/retest

kaovilai · 2022-05-04T04:26:32Z

/retest

tests/e2e/backup_restore_suite_test.go

Makefile

kaovilai · 2022-05-04T04:37:35Z

tests/e2e/sample-applications/mysql-persistent/mysql-persistent-csi-aws-template.yaml

@@ -155,7 +155,7 @@ items:
        spec:
          containers:
          - name: todolist
-            image:  quay.io/rhn_engineering_whayutin/todolist-mariadb-go:latest
+            image: quay.io/mferrato/todolist-mariadb-go:v1


What's happening here?

Wesley's image is amd64 only. I made a PR to the mig-demo-app repo konveyor/mig-demo-apps#74 to add the code enabling multiarch builds for the mariadb-based app. We discused that with @weshayutin as a temporary solution until we have a place to store the multiarch manifest. But I'd rather store it somewhere else, if you know of a better place.

Correct.. I've just opened an issue on OADP to better describe what needs to be done here and why. #666

Pretty crazy re: the issue #

So konveyor quay org would be one

kaovilai · 2022-05-04T05:20:40Z

tests/e2e/dpa_deployment_suite_test.go

@@ -381,7 +381,7 @@ var _ = Describe("Configuration testing for DPA Custom Resource", func() {
 	}

 	awsTests := []TableEntry{
-		Entry("AWS Without Region No S3ForcePathStyle with BackupImages false should succeed", InstallCase{
+		Entry("AWS Without Region No S3ForcePathStyle with BackupImages false should succeed", Label("aws"), InstallCase{


I would rather see this label added in a for loop instead since that's the whole point of a separate awsTests declaration. But I am aware this is not possible right now.
onsi/ginkgo#974 might allow this in the future.

Co-authored-by: Tiger Kaovilai <passawit.kaovilai@gmail.com>

Mathieu-Ferraton · 2022-05-04T09:17:20Z

/retest

openshift-ci · 2022-05-04T10:45:43Z

@Mathieu-Ferraton: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

weshayutin · 2022-05-04T13:26:31Z

@hhpatel14 @deepakraj1997 please review when you have a moment :)

weshayutin · 2022-05-04T13:27:34Z

Makefile

-TEST_FILTER := $(shell echo '! aws && ! gcp && ! azure' | sed -r "s/[&]* [!] $(CLUSTER_TYPE)|[!] $(CLUSTER_TYPE) [&]*//")
+TEST_FILTER := ($(shell echo '! aws && ! gcp && ! azure && ! ibmcloud' | \
+sed -r "s/[&]* [!] $(CLUSTER_TYPE)|[!] $(CLUSTER_TYPE) [&]*//")) || $(CLUSTER_TYPE)
+#TEST_FILTER := $(shell echo '! aws && ! gcp && ! azure' | sed -r "s/[&]* [!] $(CLUSTER_TYPE)|[!] $(CLUSTER_TYPE) [&]*//")


nit.. probably can remove this :)

we can remove the commented line, but i think we can keep the test_filter as we can use it to run cloud specific tests in future.

deepakraj1997 · 2022-05-04T13:49:36Z

tests/e2e/scripts/ibmcloud_settings.sh

+            "config": {
+              "profile": "$BSL_AWS_PROFILE",
+              "region": "$BSL_REGION",
+              "s3ForcePathStyle": "true",


@Mathieu-Ferraton @kaovilai Wont this set s3ForcePathStyle for all the SPECs that are running ? I think we explicitly set these in some tests and remove in some tests.

@deepakraj1997 You're right, but I think these are aws specific tests, which we want to skip for ibmcloud clusters (this can be discussed further though). If we use IBM COS bucket as BSL with ibmcloud/powerVS clusters, then we need to keep this to true, or fork an ibmcloud plugin out of the aws one.

@deepakraj1997 This is fine. It would apply to all specs within the ibmcloud which have to use aws plugin via the s3ForcePathStyle to work.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 13, 2022

openshift-ci bot requested review from hhpatel14 and jmontleon April 13, 2022 14:29

openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 13, 2022

openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 14, 2022

kaovilai added the testing label Apr 29, 2022

Mathieu-Ferraton force-pushed the ibmcloud-e2e branch from eaa6a91 to cb0e6a8 Compare April 29, 2022 10:12

Mathieu-Ferraton marked this pull request as ready for review April 29, 2022 10:17

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 29, 2022

openshift-ci bot requested review from JaydipGabani and sseago April 29, 2022 10:18

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 3, 2022

add ressources for ibmcloud/powervs e2e testing

6f324b9

improve test filtering and add labels to aws specific test cases

Mathieu-Ferraton force-pushed the ibmcloud-e2e branch from cb0e6a8 to 3129668 Compare May 3, 2022 13:22

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 3, 2022

use multi-arch image for todolist sample app

6e5eaea

Mathieu-Ferraton force-pushed the ibmcloud-e2e branch from 0e9dc22 to 6e5eaea Compare May 3, 2022 13:26

kaovilai reviewed May 4, 2022

View reviewed changes

tests/e2e/backup_restore_suite_test.go Outdated Show resolved Hide resolved

kaovilai reviewed May 4, 2022

View reviewed changes

Makefile Outdated Show resolved Hide resolved

kaovilai reviewed May 4, 2022

View reviewed changes

Mathieu-Ferraton and others added 2 commits May 4, 2022 09:23

Update tests/e2e/backup_restore_suite_test.go

cb992db

Co-authored-by: Tiger Kaovilai <passawit.kaovilai@gmail.com>

Update Makefile

0194f5f

Co-authored-by: Tiger Kaovilai <passawit.kaovilai@gmail.com>

weshayutin reviewed May 4, 2022

View reviewed changes

deepakraj1997 reviewed May 4, 2022

View reviewed changes

kaovilai approved these changes May 5, 2022

View reviewed changes

kaovilai merged commit 3fe6c28 into openshift:master May 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ibmcloud e2e #636

Ibmcloud e2e #636

Mathieu-Ferraton commented Apr 13, 2022

openshift-ci bot commented Apr 13, 2022

kaovilai commented Apr 14, 2022

Mathieu-Ferraton commented May 3, 2022

kaovilai commented May 4, 2022

kaovilai May 4, 2022

Mathieu-Ferraton May 4, 2022

weshayutin May 4, 2022

kaovilai May 4, 2022

kaovilai May 4, 2022

Mathieu-Ferraton commented May 4, 2022

openshift-ci bot commented May 4, 2022

weshayutin commented May 4, 2022

weshayutin May 4, 2022

deepakraj1997 May 4, 2022

deepakraj1997 May 4, 2022

Mathieu-Ferraton May 4, 2022

kaovilai May 4, 2022

Ibmcloud e2e #636

Ibmcloud e2e #636

Conversation

Mathieu-Ferraton commented Apr 13, 2022

openshift-ci bot commented Apr 13, 2022

kaovilai commented Apr 14, 2022

Mathieu-Ferraton commented May 3, 2022

kaovilai commented May 4, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mathieu-Ferraton commented May 4, 2022

openshift-ci bot commented May 4, 2022

weshayutin commented May 4, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment