Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: Bump stretchr/testify to v1.3.0 #1515

Conversation

wking
Copy link
Member

@wking wking commented Apr 1, 2019

Pulling in stretchr/testify@199de5f3a4 (stretchr/testify#648) to drop the "Please consider promoting this project..." deviation from the stock MIT license.

Generated with:

$ dep ensure -update github.com/stretchr/testify

using:

$ dep version
dep:
 version     : v0.5.1
 build date  : 2019-03-20
 git hash    : faa61893
 go version  : go1.10.3
 go compiler : gc
 platform    : linux/amd64
 features    : ImportDuringSolve=false

Pulling in stretchr/testify@199de5f3a4 (Update the LICENSE to match
the 'standard' MIT license file, 2018-08-16, stretchr/testify#648) to
drop the "Please consider promoting this project..." deviation from
the stock MIT license.

Generated with:

  $ dep ensure -update github.com/stretchr/testify

using:

  $ dep version
  dep:
   version     : v0.5.1
   build date  : 2019-03-20
   git hash    : faa61893
   go version  : go1.10.3
   go compiler : gc
   platform    : linux/amd64
   features    : ImportDuringSolve=false
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 1, 2019
@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member Author

wking commented Apr 3, 2019

images:

could not wait for build: the build installer failed after 6m36s with reason DockerBuildFailed: Docker build strategy has failed

/retest

@wking
Copy link
Member Author

wking commented Apr 3, 2019

images:

could not wait for build: the build installer failed after 3m59s with reason DockerBuildFailed: Docker build strategy has failed.

again. So I deleted the ci-op-bbxi6nt6 namespace/project in case that clears a stuck cache.

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit c4c4893 into openshift:master Apr 4, 2019
@wking wking deleted the bump-stretchr-testify-for-straight-license branch April 4, 2019 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants