Bug 2067893: apply upstream prometheus/client_golang fix

[flavianmissi]

Taken from prometheus/client_golang#987
and manually applied to relevant files.

[openshift-ci]

@flavianmissi: This pull request references Bugzilla bug 2067893, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (3.11.z) matches configured target release for branch (3.11.z)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @xiuwang

In response to this:

WIP Bug 2067893: apply upstream prometheus/client_golang fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dmage]

can you use glide to get new client_golang?

[openshift-ci]

@flavianmissi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[flavianmissi]

can you use glide to get new client_golang?

It doesn't work. Glide tries to update all packages (there seems to be no way to update a single pkg).
Which fails:

[ERROR]	Error scanning github.com/cespare/xxhash/v2: cannot find package "." in:
	~/.glide/cache/src/https-github.com-cespare-xxhash/v2

github.com/cespare/xxhash doesn't have a v2 directory so we can't install it without go mod.

[dmage]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, flavianmissi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dmage]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@flavianmissi: All pull requests linked via external trackers have merged:

• openshift/image-registry#331

Bugzilla bug 2067893 has been moved to the MODIFIED state.

In response to this:

Bug 2067893: apply upstream prometheus/client_golang fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.