Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-33742: setting higher priority class for external-dns pods #4050

Merged
merged 2 commits into from
May 22, 2024

Conversation

mukrishn
Copy link
Member

What this PR does / why we need it:
Hypershift operator pods are created with higher PriorityClass but external-dns, to create a successful HCP we need both of them to up and available. Due to default priority class on external-dns, this pod gets evicted by the scheduler to fit higher priorityClass pods when there is no available space on suitable nodes.

Now setting the same priorityClassName used by the operator pod for external-dns pod as well.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes # OCPBUGS-33742

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

due to default priority class, more likely this pod could be evicted by the scheduler to fit higher priorityClass pods  if there is no available space on a suitable node.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 17, 2024
@openshift-ci-robot
Copy link

@mukrishn: This pull request references Jira Issue OCPBUGS-33742, which is invalid:

  • expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it:
Hypershift operator pods are created with higher PriorityClass but external-dns, to create a successful HCP we need both of them to up and available. Due to default priority class on external-dns, this pod gets evicted by the scheduler to fit higher priorityClass pods when there is no available space on suitable nodes.

Now setting the same priorityClassName used by the operator pod for external-dns pod as well.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes # OCPBUGS-33742

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 17, 2024
@openshift-ci openshift-ci bot added area/cli Indicates the PR includes changes for CLI and removed do-not-merge/needs-area labels May 17, 2024
@csrwng
Copy link
Contributor

csrwng commented May 17, 2024

/approve

Copy link
Contributor

openshift-ci bot commented May 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, mukrishn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2024
@csrwng
Copy link
Contributor

csrwng commented May 17, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 17, 2024
@openshift-ci-robot
Copy link

@csrwng: This pull request references Jira Issue OCPBUGS-33742, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the area/ci-tooling Indicates the PR includes changes for CI or tooling label May 17, 2024
@mukrishn
Copy link
Member Author

/retest

@enxebre
Copy link
Member

enxebre commented May 20, 2024

/retest
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c698d1d and 2 for PR HEAD 2a737f1 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c5401ca and 1 for PR HEAD 2a737f1 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f91af53 and 0 for PR HEAD 2a737f1 in total

Copy link
Contributor

openshift-ci bot commented May 21, 2024

@mukrishn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure 2a737f1 link false /test e2e-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/hold

Revision 2a737f1 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2024
@csrwng
Copy link
Contributor

csrwng commented May 21, 2024

/hold cancel
/retest-required

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit fa8adc7 into openshift:main May 22, 2024
12 of 13 checks passed
@openshift-ci-robot
Copy link

@mukrishn: Jira Issue OCPBUGS-33742: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33742 has been moved to the MODIFIED state.

In response to this:

What this PR does / why we need it:
Hypershift operator pods are created with higher PriorityClass but external-dns, to create a successful HCP we need both of them to up and available. Due to default priority class on external-dns, this pod gets evicted by the scheduler to fit higher priorityClass pods when there is no available space on suitable nodes.

Now setting the same priorityClassName used by the operator pod for external-dns pod as well.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes # OCPBUGS-33742

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants