-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-33742: setting higher priority class for external-dns pods #4050
Conversation
due to default priority class, more likely this pod could be evicted by the scheduler to fit higher priorityClass pods if there is no available space on a suitable node.
@mukrishn: This pull request references Jira Issue OCPBUGS-33742, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csrwng, mukrishn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/jira refresh |
@csrwng: This pull request references Jira Issue OCPBUGS-33742, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
/retest |
@mukrishn: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/hold Revision 2a737f1 was retested 3 times: holding |
/hold cancel |
fa8adc7
into
openshift:main
@mukrishn: Jira Issue OCPBUGS-33742: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-33742 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
What this PR does / why we need it:
Hypershift operator pods are created with higher
PriorityClass
butexternal-dns
, to create a successful HCP we need both of them to up and available. Due todefault
priority class onexternal-dns
, this pod gets evicted by the scheduler to fit higher priorityClass pods when there is no available space on suitable nodes.Now setting the same
priorityClassName
used by theoperator
pod forexternal-dns
pod as well.Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)
format, where issue_number might be a GitHub issue, or a Jira story:Fixes # OCPBUGS-33742
Checklist