OCPBUGS-33802: don't delay new cluster creation #4045
Conversation
openshift-ci-robot
added
jira/severity-important
|
@stevekuznetsov: This pull request references Jira Issue OCPBUGS-33802, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
area/ci-tooling
hypershift-operator/controllers/hostedclustersizing/hostedclustersizing_controller.go
Outdated
Show resolved
Hide resolved
stevekuznetsov
force-pushed
the
skuznets/allow-new-clusters
branch
from
3528ca8
to
e05d6d3
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csrwng, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required |
|
/lgtm |
|
/jira refresh The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity. |
openshift-ci-robot
added
jira/invalid-bug
|
@openshift-bot: This pull request references Jira Issue OCPBUGS-33802, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/override ci/prow/e2e-aws |
|
Overriding as we don't test this in CI |
|
@csrwng: Overrode contexts on behalf of csrwng: ci/prow/e2e-aws, ci/prow/e2e-kubevirt-aws-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/test unit |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
hmm ... Can't seem to reproduce the error. |
|
Ah, needed to rebase on your KAS status PR. |
stevekuznetsov
force-pushed
the
skuznets/allow-new-clusters
branch
from
e05d6d3
to
fddf7a3
Compare
|
/hold cancel |
openshift-ci
bot
removed
lgtm
|
/lgtm |
Before, we would make brand-new clusters sit through the transition delays erroneously. Now, we allow them to take on their first size without any delay. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Before, we would enforce global concurrency limits on brand new clusters joining the fleet and being given a size. This is not tenable with an SLA for cluster bringup, so we no longer do that. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
stevekuznetsov
force-pushed
the
skuznets/allow-new-clusters
branch
from
fddf7a3
to
1e6eedc
Compare
|
/lgtm |
|
/override ci/prow/e2e-kubevirt-aws-ovn |
|
@csrwng: Overrode contexts on behalf of csrwng: ci/prow/e2e-kubevirt-aws-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit c5401ca
into
openshift:main
|
@stevekuznetsov: Jira Issue OCPBUGS-33802: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-33802 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@stevekuznetsov: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-hypershift-container-v4.17.0-202405202113.p0.gc5401ca.assembly.stream.el9 for distgit hypershift. |
hostedclustersizing: don't enforce delays on brand-new clusters
Before, we would make brand-new clusters sit through the transition
delays erroneously. Now, we allow them to take on their first size
without any delay.
Signed-off-by: Steve Kuznetsov skuznets@redhat.com
hostedclustersizing: don't enforce concurrency on new clusters
Before, we would enforce global concurrency limits on brand new clusters
joining the fleet and being given a size. This is not tenable with an
SLA for cluster bringup, so we no longer do that.
Signed-off-by: Steve Kuznetsov skuznets@redhat.com