Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA: Bump library-go dependency and bump LatestSupportedVersion to 4.17.0 #4044

Merged
merged 1 commit into from
May 21, 2024
Merged

NO-JIRA: Bump library-go dependency and bump LatestSupportedVersion to 4.17.0 #4044

merged 1 commit into from
May 21, 2024

Conversation

orenc1
Copy link
Contributor

@orenc1 orenc1 commented May 16, 2024

This is needed in order to include the fix at openshift/library-go#1697

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 16, 2024
@openshift-ci-robot
Copy link

@orenc1: This pull request explicitly references no jira issue.

In response to this:

This is needed in order to include the fix at openshift/library-go#1697

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from csrwng and sjenning May 16, 2024 14:37
@openshift-ci openshift-ci bot added area/control-plane-pki-operator Indicates the PR includes changes for the control plane PKI operator - in an OCP release and removed do-not-merge/needs-area labels May 16, 2024
@openshift-ci openshift-ci bot added the area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release label May 16, 2024
@gcs278 gcs278 mentioned this pull request May 16, 2024
Merged
@candita
Copy link

candita commented May 16, 2024

Out of VPCs! Trying again.

Error: failed to create infra: failed to create VPC: VpcLimitExceeded: The maximum number of VPCs has been reached.
status code: 400, request id: 5ac78246-5344-40eb-933c-e627ec1d4a52
failed to create infra: failed to create VPC: VpcLimitExceeded: The maximum number of VPCs has been reached.
status code: 400, request id: 5ac78246-5344-40eb-933c-e627ec1d4a52
{"component":"entrypoint","error":"wrapped process failed: exit status

/retest-required

@sanchezl
Copy link

/retest-required

@orenc1 orenc1 force-pushed the bump_library_go branch 2 times, most recently from e970782 to dafe024 Compare May 17, 2024 09:47
@orenc1
Copy link
Contributor Author

orenc1 commented May 17, 2024 •
edited

a pull secret added under the ServiceAccount's .imagePullSecrets[] is being reverted by openshift-controller-manager, thus hotlooping errors observed.
the bug is tracked at:

@orenc1
Copy link
Contributor Author

orenc1 commented May 19, 2024

/test e2e-kubevirt-aws-ovn

1 similar comment
@orenc1
Copy link
Contributor Author

orenc1 commented May 20, 2024

/test e2e-kubevirt-aws-ovn

@orenc1
NO-JIRA: Bump library-go dependency
f21fa42 
This is needed in order to include the fix at openshift/library-go#1697

Signed-off-by: Oren Cohen <ocohen@redhat.com>
@orenc1
Copy link
Contributor Author

orenc1 commented May 20, 2024

openshift/release#52229 is merged, thus the kubevirt lane should be unblocked now.
/test e2e-kubevirt-aws-ovn

@orenc1 orenc1 changed the title NO-JIRA: Bump library-go dependency NO-JIRA: Bump library-go dependency and bump LatestSupportedVersion to 4.17.0 May 20, 2024
@sjenning
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: orenc1, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
@qinqon
Copy link
Contributor

qinqon commented May 21, 2024

/test e2e-kubevirt-aws-ovn
Not related

 Pod got deleted unexpectedly 

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 21, 2024

@orenc1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure f21fa42 link false /test e2e-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5934604 into openshift:main May 21, 2024
12 of 13 checks passed
@orenc1 orenc1 deleted the bump_library_go branch May 21, 2024 11:50
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.17.0-202405211341.p0.g5934604.assembly.stream.el9 for distgit hypershift.
All builds following this will include this PR.

stevekuznetsov
stevekuznetsov reviewed May 21, 2024
View reviewed changes
control-plane-pki-operator/certrotationcontroller/certrotationcontroller.go
@@ -91,8 +91,6 @@ func NewCertRotationController(
Client: kubeClient.CoreV1(),
EventRecorder: eventRecorder,
Owner: ownerRef,
JiraComponent: "HOSTEDCP",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did they remove these fields?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, JiraComponent and Description have been removed from RotatedSigningCASecret struct.
https://github.com/openshift/library-go/blob/d72e84d1d42ea17b415daaea8bdcabed55adca69/pkg/operator/certrotation/signer.go#L24-L61

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixing in #4070

orenc1 added a commit to orenc1/hypershift that referenced this pull request May 21, 2024
@orenc1
Reinstate wrongly removed fields from cert rotation objects
6507794 
in openshift#4044, the JiraComponent and Description have been removed from the cert rotation objects since the struct have been changed
and these fields were no longer exist. Afterwards it has been turned out that these fields were moved to AdditionalAnnotations.
This PR reinstates the dropped fields.

Signed-off-by: Oren Cohen <ocohen@redhat.com>
@orenc1 orenc1 mentioned this pull request May 21, 2024
Merged
4 tasks
Tal-or pushed a commit to Tal-or/hypershift that referenced this pull request May 29, 2024
@orenc1 @Tal-or
Reinstate wrongly removed fields from cert rotation objects
28cd142 
in openshift#4044, the JiraComponent and Description have been removed from the cert rotation objects since the struct have been changed
and these fields were no longer exist. Afterwards it has been turned out that these fields were moved to AdditionalAnnotations.
This PR reinstates the dropped fields.

Signed-off-by: Oren Cohen <ocohen@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevekuznetsov stevekuznetsov stevekuznetsov left review comments

@csrwng csrwng Awaiting requested review from csrwng

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@sjenning sjenning

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-pki-operator Indicates the PR includes changes for the control plane PKI operator - in an OCP release area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@orenc1 @openshift-ci-robot @candita @sanchezl @sjenning @qinqon @openshift-bot @stevekuznetsov