Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.15] HOSTEDCP-1518: Preserve container resource requests and limits #4032

Conversation

lucaspalm
Copy link
Contributor

This is a manual cherry-pick of the changes from #3864.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 14, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 14, 2024

@lucaspalm: This pull request references HOSTEDCP-1518 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.z" version, but no target version was set.

In response to this:

This is a manual cherry-pick of the changes from #3864.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release and removed do-not-merge/needs-area labels May 14, 2024
@lucaspalm lucaspalm force-pushed the release-4.15_cherry-pick_hostedcp-1518 branch from 3515f8f to e0965bb Compare May 14, 2024 18:28
@stevekuznetsov
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2024
@stevekuznetsov
Copy link
Contributor

@lucaspalm use UPDATE=1 go test ./... to update fixtures:

 --- FAIL: TestReconcileDeployment (0.04s)
    --- FAIL: TestReconcileDeployment/No_private_apiserver_connectivity,_proxy_apiserver_address_is_set (0.02s)
        clusternetworkoperator_test.go:90: got diff between expected and actual result:
            file: /go/src/github.com/openshift/hypershift/control-plane-operator/controllers/hostedcontrolplane/cno/testdata/zz_fixture_TestReconcileDeployment_No_private_apiserver_connectivity__proxy_apiserver_address_is_set.yaml
            diff:
              (
              	"""
              	... // 39 identical lines
              	          value: "true"
              	        - name: HOSTED_CLUSTER_NAME
            - 	        - name: CA_CONFIG_MAP
            - 	        - name: CA_CONFIG_MAP_KEY
              	        - name: TOKEN_AUDIENCE
              	        - name: RELEASE_VERSION
              	... // 60 identical lines
              	        - /usr/bin/control-plane-operator
              	        - konnectivity-socks5-proxy
            - 	        - --disable-resolver
            + 	        - --resolve-from-guest-cluster-dns=true
              	        env:
              	        - name: KUBECONFIG
              	... // 91 identical lines
              	"""
              ) 

Copy link
Contributor

@rtheis rtheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rtheis
Copy link
Contributor

rtheis commented May 15, 2024

/retest-required

@csrwng
Copy link
Contributor

csrwng commented May 16, 2024

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c825e42 and 2 for PR HEAD e0965bb in total

@rtheis
Copy link
Contributor

rtheis commented May 16, 2024

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 70ec14d and 1 for PR HEAD e0965bb in total

@rtheis
Copy link
Contributor

rtheis commented May 16, 2024

/retest-required

@lucaspalm
Copy link
Contributor Author

/retest

@rtheis
Copy link
Contributor

rtheis commented May 16, 2024

/retest-required

1 similar comment
@rtheis
Copy link
Contributor

rtheis commented May 17, 2024

/retest-required

@rtheis
Copy link
Contributor

rtheis commented May 17, 2024

/test e2e-aws

1 similar comment
@rtheis
Copy link
Contributor

rtheis commented May 17, 2024

/test e2e-aws

@lucaspalm
Copy link
Contributor Author

/retest

@rtheis
Copy link
Contributor

rtheis commented May 17, 2024

/test e2e-aws

1 similar comment
@rtheis
Copy link
Contributor

rtheis commented May 17, 2024

/test e2e-aws

@rtheis
Copy link
Contributor

rtheis commented May 18, 2024

/test e2e-aws

@rtheis
Copy link
Contributor

rtheis commented May 18, 2024

/retest-required

@rtheis
Copy link
Contributor

rtheis commented May 19, 2024

/test e2e-aws

@lucaspalm lucaspalm force-pushed the release-4.15_cherry-pick_hostedcp-1518 branch from e0965bb to d9737ed Compare May 20, 2024 15:28
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
@lucaspalm
Copy link
Contributor Author

rebased to hopefully fix the konflux test

@bryan-cox
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
Copy link
Contributor

@rtheis rtheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, lucaspalm, rtheis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented May 20, 2024

@lucaspalm: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 4cc91fe into openshift:release-4.15 May 20, 2024
9 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.15.0-202405201941.p0.g4cc91fe.assembly.stream.el9 for distgit hypershift.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants