-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.15] HOSTEDCP-1518: Preserve container resource requests and limits #4032
[release-4.15] HOSTEDCP-1518: Preserve container resource requests and limits #4032
Conversation
@lucaspalm: This pull request references HOSTEDCP-1518 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.z" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
3515f8f
to
e0965bb
Compare
/lgtm |
@lucaspalm use
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest-required |
/approve |
/retest-required |
/retest-required |
/retest |
/retest-required |
1 similar comment
/retest-required |
/test e2e-aws |
1 similar comment
/test e2e-aws |
/retest |
/test e2e-aws |
1 similar comment
/test e2e-aws |
/test e2e-aws |
/retest-required |
/test e2e-aws |
e0965bb
to
d9737ed
Compare
rebased to hopefully fix the konflux test |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csrwng, lucaspalm, rtheis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@lucaspalm: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4cc91fe
into
openshift:release-4.15
[ART PR BUILD NOTIFIER] This PR has been included in build ose-hypershift-container-v4.15.0-202405201941.p0.g4cc91fe.assembly.stream.el9 for distgit hypershift. |
This is a manual cherry-pick of the changes from #3864.