Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-31446: Add TrustedBundles to OAS container #4031

Merged
merged 1 commit into from
May 23, 2024
Merged

OCPBUGS-31446: Add TrustedBundles to OAS container #4031

merged 1 commit into from
May 23, 2024

Conversation

jparrill
Copy link
Contributor

Which issue(s) this PR fixes:
Fixes #OCPBUGS-31446

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 14, 2024
@openshift-ci-robot
Copy link

@jparrill: This pull request references Jira Issue OCPBUGS-31446, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Which issue(s) this PR fixes:
Fixes #OCPBUGS-31446

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from csrwng and enxebre May 14, 2024 15:32
@openshift-ci openshift-ci bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels May 14, 2024
@netlify Netlify
Copy link

netlify bot commented May 14, 2024 •
edited

✅ Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit e174f57
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/664f49e80a117200083b3df9
😎 Deploy Preview https://deploy-preview-4031--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jparrill
Copy link
Contributor Author

/retest

stevekuznetsov
stevekuznetsov approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@stevekuznetsov stevekuznetsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LiangquanLi930
Copy link
Member

/jira refresh

@openshift-ci-robot
Copy link

@LiangquanLi930: This pull request references Jira Issue OCPBUGS-31446, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@LiangquanLi930
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 16, 2024
@openshift-ci-robot
Copy link

@LiangquanLi930: This pull request references Jira Issue OCPBUGS-31446, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @LiangquanLi930

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 16, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 82db100 and 2 for PR HEAD f32cd4e in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8f0d792 and 1 for PR HEAD f32cd4e in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a492a9a and 0 for PR HEAD f32cd4e in total

@openshift-ci-robot
Copy link

/hold

Revision f32cd4e was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2024
@openshift-bot
Copy link

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

@openshift-cherrypick-robot
Copy link

@jparrill: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.16 release-4.15 release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jparrill
Copy link
Contributor Author

/jira refresh
/test e2e-aws

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 20, 2024
@openshift-ci-robot
Copy link

@jparrill: This pull request references Jira Issue OCPBUGS-31446, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @LiangquanLi930

In response to this:

/jira refresh
/test e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 20, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 22, 2024
@jparrill
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 22, 2024
csrwng
csrwng reviewed May 22, 2024
View reviewed changes
Copy link
Contributor

@csrwng csrwng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments

control-plane-operator/controllers/hostedcontrolplane/oapi/deployment.go Outdated Show resolved Hide resolved
control-plane-operator/controllers/hostedcontrolplane/oapi/deployment.go Outdated Show resolved Hide resolved
@jparrill
Copy link
Contributor Author

/retest

@jparrill
OCPBUGS-31446: Add TrustedBundles to OAS container
e174f57 
Signed-off-by: Juan Manuel Parrilla Madrid <jparrill@redhat.com>
@bryan-cox
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 23, 2024

@jparrill: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-kubevirt-azure-ovn e174f57 link false /test e2e-kubevirt-azure-ovn
ci/prow/e2e-azure e174f57 link false /test e2e-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 41fe333 into openshift:main May 23, 2024
12 of 14 checks passed
@openshift-ci-robot
Copy link

@jparrill: Jira Issue OCPBUGS-31446: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-31446 has been moved to the MODIFIED state.

In response to this:

Which issue(s) this PR fixes:
Fixes #OCPBUGS-31446

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 23, 2024
Merged
@openshift-cherrypick-robot
Copy link

@jparrill: new pull request created: #4087

In response to this:

/cherry-pick release-4.16 release-4.15 release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jparrill
Copy link
Contributor Author

/cherry-pick release-4.16 release-4.15 release-4.14

@openshift-cherrypick-robot
Copy link

@jparrill: new pull request could not be created: failed to create pull request against openshift/hypershift#release-4.16 from head openshift-cherrypick-robot:cherry-pick-4031-to-release-4.16: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-4031-to-release-4.16."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-4.16 release-4.15 release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jparrill
Copy link
Contributor Author

/cherry-pick release-4.16,release-4.15,release-4.14

@openshift-cherrypick-robot
Copy link

@jparrill: cannot checkout release-4.16,release-4.15,release-4.14: error checking out "release-4.16,release-4.15,release-4.14": exit status 1 error: pathspec 'release-4.16,release-4.15,release-4.14' did not match any file(s) known to git

In response to this:

/cherry-pick release-4.16,release-4.15,release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jparrill
Copy link
Contributor Author

/cherry-pick release-4.16

@openshift-cherrypick-robot
Copy link

@jparrill: new pull request could not be created: failed to create pull request against openshift/hypershift#release-4.16 from head openshift-cherrypick-robot:cherry-pick-4031-to-release-4.16: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-4031-to-release-4.16."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csrwng csrwng csrwng left review comments

@stevekuznetsov stevekuznetsov stevekuznetsov approved these changes

@enxebre enxebre Awaiting requested review from enxebre

@LiangquanLi930 LiangquanLi930 Awaiting requested review from LiangquanLi930

Assignees

@stevekuznetsov stevekuznetsov

@bryan-cox bryan-cox

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jparrill @openshift-ci-robot @LiangquanLi930 @openshift-bot @openshift-cherrypick-robot @bryan-cox @csrwng @stevekuznetsov