Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-32813: Revert "Merge pull request #261 from Elbehery/rebase-etcd-3.5.13-open… #265

Merged
merged 1 commit into from
May 20, 2024
Merged

OCPBUGS-32813: Revert "Merge pull request #261 from Elbehery/rebase-etcd-3.5.13-open… #265

merged 1 commit into from
May 20, 2024

Conversation

dusk125
Copy link

@dusk125 dusk125 commented Apr 24, 2024

…shift-4.14"

We're reverting this to have openshift/etcd stay in sync with the Go version expected at a given Openshift version: for 4.14, that's 1.20.

@dusk125
Revert "Merge pull request openshift#261 from Elbehery/rebase-etcd-3.…
51a70ff 
…5.13-openshift-4.14"

This reverts commit b0c0321, reversing
changes made to 070ba48.
@dusk125 dusk125 changed the title Revert "Merge pull request #261 from Elbehery/rebase-etcd-3.5.13-open… OCPBUGS-32813: Revert "Merge pull request #261 from Elbehery/rebase-etcd-3.5.13-open… Apr 24, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 24, 2024
@openshift-ci-robot
Copy link

@dusk125: This pull request references Jira Issue OCPBUGS-32813, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected Jira Issue OCPBUGS-32813 to depend on a bug targeting a version in 4.15.0, 4.15.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

…shift-4.14"

We're reverting this to have openshift/etcd stay in sync with the Go version expected at a given Openshift version: for 4.14, that's 1.20.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dusk125
Copy link
Author

dusk125 commented Apr 24, 2024

/jira refresh

@openshift-ci-robot
Copy link

@dusk125: This pull request references Jira Issue OCPBUGS-32813, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected dependent Jira Issue OCPBUGS-32768 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2024
@Elbehery
Copy link

/lgtm
/approve

@tjungblu
Copy link

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 24, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 24, 2024

@dusk125: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-etcd-recovery 51a70ff link false /test e2e-aws-etcd-recovery

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hasbro17
Copy link

/lgtm

/assign @sandeepknd (for the cherry-pick-approved label)
/assign @soltysh (for the jira label)

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2024
@dusk125
Copy link
Author

dusk125 commented Apr 25, 2024

I accidentally messed these up...fixing
/assign @sandeepknd (for the cherry-pick-approved label)
/assign @soltysh (for the jira label)

geliu2016
geliu2016 approved these changes Apr 26, 2024
View reviewed changes
Copy link

@geliu2016 geliu2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 26, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dusk125, Elbehery, geliu2016, hasbro17

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Elbehery,dusk125,hasbro17]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Elbehery
Copy link

/jira refresh

@openshift-ci-robot
Copy link

@Elbehery: This pull request references Jira Issue OCPBUGS-32813, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dusk125
Copy link
Author

dusk125 commented May 3, 2024

/jira refresh

@openshift-ci-robot
Copy link

@dusk125: This pull request references Jira Issue OCPBUGS-32813, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Elbehery
Copy link

Elbehery commented May 3, 2024

/retest-required

@dusk125
Copy link
Author

dusk125 commented May 20, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 20, 2024
@openshift-ci-robot
Copy link

@dusk125: This pull request references Jira Issue OCPBUGS-32813, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-32768 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-32768 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
  • bug has dependents

Requesting review from QA contact:
/cc @geliu2016

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 20, 2024
@openshift-ci openshift-ci bot requested a review from geliu2016 May 20, 2024 16:45
@openshift-merge-bot openshift-merge-bot bot merged commit 5ed5044 into openshift:openshift-4.14 May 20, 2024
7 of 8 checks passed
@openshift-ci-robot
Copy link

@dusk125: Jira Issue OCPBUGS-32813: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-32813 has been moved to the MODIFIED state.

In response to this:

…shift-4.14"

We're reverting this to have openshift/etcd stay in sync with the Go version expected at a given Openshift version: for 4.14, that's 1.20.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dusk125 dusk125 deleted the revert-3.5.13-bump branch May 20, 2024 16:56
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-etcd-container-v4.14.0-202405201737.p0.g5ed5044.assembly.stream.el9 for distgit ose-etcd.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elbehery Elbehery Awaiting requested review from Elbehery

@hexfusion hexfusion Awaiting requested review from hexfusion

@geliu2016 geliu2016 Awaiting requested review from geliu2016

Assignees

@hasbro17 hasbro17

@geliu2016 geliu2016

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dusk125 @openshift-ci-robot @Elbehery @tjungblu @hasbro17 @openshift-bot @geliu2016