UPSTREAM <carry>: etcdctl: allow move-leader to connect to multiple e…

[tjungblu]

…ndpoints

Re-opening closed PR etcd-io#11775 which was originaly authored by benmoss. Then again opened PR etcd-io#12757 which was authored by zerodayz.

The mustClientForCmd function is responsible for parsing environment variables and flags into configuration data. A change was made in etcd-io#9382 to call Fatal if a flag is provided multiple times. This means that we cannot call the mustClientForCmd function more than once, since it will think that flags parsed the first time are now being redefined and error out.

Some people have commented about this in etcd-io#8380 but I don't think there's an open issue for it.

Signed-off-by: Thomas Jungblut tjungblu@redhat.com

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

[openshift-ci]

@tjungblu: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

UPSTREAM : etcdctl: allow move-leader to connect to multiple e…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tjungblu
Once this PR has been reviewed and has the lgtm label, please assign hasbro17 for approval by writing /assign @hasbro17 in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tjungblu]

this is a carry for https://bugzilla.redhat.com/show_bug.cgi?id=1918413
etcd-io#14434

[tjungblu]

just tested with cluster-bot, works like a charm:

sh-4.4# etcdctl member list
2d2138c1862ef2be, started, ci-ln-rpg82q2-72292-vgr8j-master-0, https://10.0.0.4:2380, https://10.0.0.4:2379, false
7e000217098b1d89, started, ci-ln-rpg82q2-72292-vgr8j-master-1, https://10.0.0.3:2380, https://10.0.0.3:2379, false
ac971fd52e8876de, started, ci-ln-rpg82q2-72292-vgr8j-master-2, https://10.0.0.5:2380, https://10.0.0.5:2379, false
sh-4.4# etcdctl move-leader ac971fd52e8876de
Leadership transferred from 7e000217098b1d89 to ac971fd52e8876de
sh-4.4# 

[EmilyM1]

/test e2e-aws-serial

[tjungblu]

/retest

[openshift-ci]

@tjungblu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-serial	2cfc6dc	link	true	/test e2e-aws-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[tjungblu]

/hold

[tjungblu]

superseded by the rebase to 3.5.5