Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: MON-3868: Crd based watch events #2350

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

WIP: MON-3868: Crd based watch events #2350

wants to merge 5 commits into from

Conversation

marioferh
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 15, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 15, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marioferh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2024
@marioferh marioferh changed the title DRAFT: Crd based watch events WIP: Crd based watch events May 15, 2024
@marioferh marioferh marked this pull request as ready for review May 15, 2024 08:41
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2024
@marioferh
Copy link
Contributor Author

/retest

@marioferh
Copy link
Contributor Author

change to go 1.22, otherwise code-generator does not work. We can wait until bump to go 1.22 or try to fix code generator with 1.21

@marioferh marioferh force-pushed the crd_based_watch_events branch 5 times, most recently from 4cbadae to f49d808 Compare May 16, 2024 15:54
@marioferh
Copy link
Contributor Author

/retest-required

@marioferh marioferh changed the title WIP: Crd based watch events WIP: MON-3868: Crd based watch events May 23, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 23, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 23, 2024 •
edited by openshift-ci bot

@marioferh: This pull request references MON-3868 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.17.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@marioferh
generate CRD's and api
bd5cc20 
Signed-off-by: Mario Fernandez <mariofer@redhat.com>
@marioferh
golang 1.22
6fcec21 
Signed-off-by: Mario Fernandez <mariofer@redhat.com>
@marioferh
add pkg/generated from codegen
3b7bff1 
Signed-off-by: Mario Fernandez <mariofer@redhat.com>
@marioferh
add reconcile logic to CR
9b8da6c 
Signed-off-by: Mario Fernandez <mariofer@redhat.com>
@marioferh
vendor
2eb17ab 
Signed-off-by: Mario Fernandez <mariofer@redhat.com>
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 27, 2024

@marioferh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/generate 2eb17ab link true /test generate
ci/prow/e2e-agnostic-operator 2eb17ab link true /test e2e-agnostic-operator
ci/prow/golangci-lint 2eb17ab link true /test golangci-lint
ci/prow/rules 2eb17ab link true /test rules
ci/prow/e2e-aws-ovn-single-node 2eb17ab link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn 2eb17ab link true /test e2e-aws-ovn
ci/prow/verify 2eb17ab link true /test verify
ci/prow/jsonnet-fmt 2eb17ab link true /test jsonnet-fmt
ci/prow/e2e-aws-ovn-upgrade 2eb17ab link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-techpreview 2eb17ab link true /test e2e-aws-ovn-techpreview
ci/prow/versions 2eb17ab link false /test versions

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rexagod rexagod Awaiting requested review from rexagod

@simonpasquier simonpasquier Awaiting requested review from simonpasquier

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marioferh @openshift-ci-robot @openshift-merge-robot