Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove job:kube_pv:count #2341

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

weirdwiz
Copy link
Contributor

@weirdwiz weirdwiz commented May 8, 2024

This commit removes job:kube_pv:count from telemetry as it's been deprecated and no longer contains any value

This commit removes job:kube_pv:count from telemetry as it's been
deprecated and no longer contains any value

Signed-off-by: Divyansh Kamboj <dkamboj@redhat.com>
Copy link
Contributor

openshift-ci bot commented May 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weirdwiz
Once this PR has been reviewed and has the lgtm label, please assign danielmellado for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented May 8, 2024

Hi @weirdwiz. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 8, 2024
@machine424
Copy link
Contributor

Thanks for this.
Do we have a guarantee that no <4.12 cluster is sending this metric anymore?
IIUC, there is no versioning on telemeter server side: https://github.com/rhobs/configuration/blob/d2353fb83f94d23a173f56b93a5329e5f85c9e13/Makefile#L110-L115 (server's allow list uses CMO's maqter)
If we remove this metric here, we may prevent those old clusters from sending it.
I think, if it's just a clean-up change, it's safer to keep things as they are.
Maybe we could mention that next to these "deprecated" comments.

Of course, if you DO want this metric to disappear, that's another discussion.
cc @jan--f @simonpasquier

@simonpasquier
Copy link
Contributor

+1 to what Ayoub said. Dropping the metric from this list means that it will be rejected on the telemeter server side. It might be better to document the metric as being deprecated and remove it once it's not available in any supported OCP version.
Anyway thanks for the clean-up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants