Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBSDOCS-883: change docs to correct retention time uwm prometheus #2277

Merged

Conversation

marioferh
Copy link
Contributor

Documentation for User Workload Monitoring implies that default retention time is 15d, when it is actually 24h in practice

Signed-off-by: Mario Fernandez <mariofer@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 7, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 7, 2024

@marioferh: This pull request references OBSDOCS-883 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Documentation for User Workload Monitoring implies that default retention time is 15d, when it is actually 24h in practice

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2024
@machine424
Copy link
Contributor

nit: I think to be future proof, it's better to explicitly set it to 24h as we do for the the platform one

DefaultRetentionValue = "15d"

In case we miss the change of the default value in prometheus-operator.

/lgtm
/hold
unhold when you want.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2024
Copy link
Member

@slashpai slashpai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@marioferh
Copy link
Contributor Author

/retest-required

@danielmellado
Copy link
Contributor

/lgtm

@danielmellado
Copy link
Contributor

/assign @bburt-rh

@danielmellado
Copy link
Contributor

/retest-required

Copy link
Contributor

openshift-ci bot commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielmellado, machine424, marioferh, slashpai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [danielmellado,machine424,marioferh,slashpai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bburt-rh
Copy link
Contributor

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Mar 25, 2024
@danielmellado
Copy link
Contributor

@marioferh mind checking @machine424 comment about the hold? I'd like to see if we get this in soon.

@machine424
Copy link
Contributor

Tell me @marioferh if you want me to take over, Eliska already tried to address this here #2332

@simonpasquier
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD f47dac6 and 2 for PR HEAD dc897bc in total

Copy link
Contributor

openshift-ci bot commented Jun 3, 2024

@marioferh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/versions dc897bc link false /test versions

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a83f250 and 1 for PR HEAD dc897bc in total

@openshift-merge-bot openshift-merge-bot bot merged commit 54e469b into openshift:master Jun 5, 2024
16 of 17 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-monitoring-operator-container-v4.17.0-202406052200.p0.g54e469b.assembly.stream.el9 for distgit cluster-monitoring-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants