-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OBSDOCS-883: change docs to correct retention time uwm prometheus #2277
OBSDOCS-883: change docs to correct retention time uwm prometheus #2277
Conversation
Signed-off-by: Mario Fernandez <mariofer@redhat.com>
@marioferh: This pull request references OBSDOCS-883 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
nit: I think to be future proof, it's better to explicitly set it to 24h as we do for the the platform one
In case we miss the change of the default value in prometheus-operator. /lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest-required |
/lgtm |
/assign @bburt-rh |
/retest-required |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielmellado, machine424, marioferh, slashpai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label docs-approved |
@marioferh mind checking @machine424 comment about the hold? I'd like to see if we get this in soon. |
Tell me @marioferh if you want me to take over, Eliska already tried to address this here #2332 |
/hold cancel |
@marioferh: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
54e469b
into
openshift:master
[ART PR BUILD NOTIFIER] This PR has been included in build cluster-monitoring-operator-container-v4.17.0-202406052200.p0.g54e469b.assembly.stream.el9 for distgit cluster-monitoring-operator. |
Documentation for User Workload Monitoring implies that default retention time is 15d, when it is actually 24h in practice