-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-30294: Add aggregate-to-view to cluster-monitoring-view #2273
base: master
Are you sure you want to change the base?
OCPBUGS-30294: Add aggregate-to-view to cluster-monitoring-view #2273
Conversation
@danielmellado: This pull request references Jira Issue OCPBUGS-20294, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@danielmellado: This pull request references Jira Issue OCPBUGS-30294, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@danielmellado: This pull request references Jira Issue OCPBUGS-30294, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielmellado, marioferh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I don't see any yaml changes and the generate job is passing, maybe the change has no effect or it's already applied. |
Since OpenShift 4.15.0, AlertManager requires the user to have an RBAC to the subresource of 'prometheuses/api'. The ClusterRole 'cluster-monitoring-view' is not configured to use aggregate-to-view [1] This commit adds the rbac.authorization.k8s.io/aggregate-to-view: 'true' label to the cluster-monitoring-view ClusterRole. [1] https://kubernetes.io/docs/reference/access-authn-authz/rbac/#default-roles-and-role-bindings Signed-off-by: Daniel Mellado <dmellado@redhat.com>
bb0dc5e
to
531c7d7
Compare
New changes are detected. LGTM label has been removed. |
@danielmellado: This pull request references Jira Issue OCPBUGS-20294, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@danielmellado: This pull request references Jira Issue OCPBUGS-30294, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@danielmellado: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/unhold |
/hold While the change might solve the reported issue, we need to review the implications.. |
@simonpasquier @machine424 @danielmellado please see my comment in bug, edit clusterrole cluster-monitoring-view to add label: rbac.authorization.k8s.io/aggregate-to-view: "true", login console with the user, could view Alerts/ALerting rules, but there is warning on page
also Forbidden error for Silences tab, can not view silences |
Since OpenShift 4.15.0, AlertManager requires the user to have an RBAC
to the subresource of 'prometheuses/api'. The ClusterRole
'cluster-monitoring-view' is not configured to use aggregate-to-view [1]
This commit adds the rbac.authorization.k8s.io/aggregate-to-view: 'true'
label to the cluster-monitoring-view ClusterRole.
[1] https://kubernetes.io/docs/reference/access-authn-authz/rbac/#default-roles-and-role-bindings
Signed-off-by: Daniel Mellado dmellado@redhat.com