HOSTEDCP-1044: Add nodepools telemetry metrics for HyperShift

[muraee]

• hypershift:nodepools:size
• hypershift:nodepools:available_replicas

requires: openshift/hypershift#3593

• I added CHANGELOG entry for this change.
• No user facing changes, so no entry in CHANGELOG was needed.

[openshift-ci-robot]

@muraee: This pull request references HOSTEDCP-1044 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target only the "4.16.0" version, but multiple target versions were set.

In response to this:

• hypershift:nodepools:size
• hypershift:nodepools:available_replicas

requires: openshift/hypershift#3593

• I added CHANGELOG entry for this change.
• No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: muraee
Once this PR has been reviewed and has the lgtm label, please assign danielmellado for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[muraee]

/retest-required

[muraee]

cc @simonpasquier

[simonpasquier]

From openshift/hypershift#3593 (comment)

changed to aggregate per HostedCluster, the maximum cardinality would between 80-100

So at most a single management cluster running the hypershift operator could generate 2 x 100 = 200 series. It's still way above the "automatically approved" limit (https://rhobs-handbook.netlify.app/products/openshiftmonitoring/telemetry.md/#request-approval).

cc @jan--f @moadz

[simonpasquier]

IIUC HostedCluster = (cluster_name, exported_namespace) labels. Could these values contain identifying information?

[muraee]

I don't think so

[simonpasquier]

Another question: is there a need to correlate these metrics with the telemetry metrics emitted from the guest cluster?

[muraee]

So at most a single management cluster running the hypershift operator could generate 2 x 100 = 200 series

per HostedCluster, multiple HostedClusters can be created in the same management cluster.

Another question: is there a need to correlate these metrics with the telemetry metrics emitted from the guest cluster?

No need cc @zanetworker

[simonpasquier]

So at most a single management cluster running the hypershift operator could generate 2 x 100 = 200 series

per HostedCluster, multiple HostedClusters can be created in the same management cluster.

I don't get it. Say that a management cluster runs 100 HostedClusters then the cardinality of cluster_name:hypershift_nodepools_size:sum will be 100 (and the same for luster_name:hypershift_nodepools_available_replicas:sum hence the 200 series).Do you confirm?

[simonpasquier]

cc @zanetworker, see #2265 (comment) (the previous mention failed).

[muraee]

hence the 200 series).Do you confirm?

@simonpasquier exactly right. sorry I was thinking of something else.

[zanetworker]

Another question: is there a need to correlate these metrics with the telemetry metrics emitted from the guest cluster?

No need @simonpasquier

[openshift-ci]

@muraee: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/versions	1446005	link	false	/test versions
ci/prow/e2e-aws-ovn-single-node	1446005	link	false	/test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[muraee]

/retest-required