feat(cmd): apply MultiNamespacedCacheBuilder, bump-up controller-runtime to 0.8.3 #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
Codecov Report
@@ Coverage Diff @@
## master #176 +/- ##
==========================================
+ Coverage 26.96% 27.19% +0.23%
==========================================
Files 33 33
Lines 2440 2445 +5
==========================================
+ Hits 658 665 +7
+ Misses 1723 1722 -1
+ Partials 59 58 -1
|
boranx
added
do-not-merge/blocked-paths
boranx
changed the title
boranx
changed the title
boranx
force-pushed
the
MultiNamespacedCacheBuilder
branch
from
9b12087
to
567b7a4
Compare
lisa
reviewed
May 13, 2021
| @@ -36,7 +36,7 @@ spec: | |||
| env: | |||
| # "" so that the cache can read objects outside its namespace | |||
| - name: WATCH_NAMESPACE | |||
| value: "" | |||
| value: "openshift-sre-sshd,openshift-cloud-ingress-operator,openshift-ingress,openshift-ingress-operator,openshift-kube-apiserver" | |||
There was a problem hiding this comment.
Does this work?? That's awesome, and way better.
There was a problem hiding this comment.
boranx
changed the title
boranx
changed the title
boranx
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
boranx
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
boranx
changed the title
boranx
changed the title
boranx
force-pushed
the
MultiNamespacedCacheBuilder
branch
3 times, most recently
from
9f0579c
to
96404a0
Compare
openshift-ci
bot
added
the
needs-rebase
boranx
force-pushed
the
MultiNamespacedCacheBuilder
branch
from
96404a0
to
e816cfe
Compare
openshift-ci
bot
removed
the
needs-rebase
boranx
force-pushed
the
MultiNamespacedCacheBuilder
branch
3 times, most recently
from
45abeb2
to
93cf3f2
Compare
2uasimojo
reviewed
May 24, 2021
openshift-ci
bot
added
lgtm
boranx
force-pushed
the
MultiNamespacedCacheBuilder
branch
3 times, most recently
from
12e1cfe
to
7d662bc
Compare
…ner-runtime to 0.8.3
boranx
force-pushed
the
MultiNamespacedCacheBuilder
branch
from
7d662bc
to
ce32228
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: boranx, fahlmant The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://issues.redhat.com/browse/OSD-7118
unblocked
Currently, this PR is blocked as it would require go 1.15, bp supports 1.13.8 as of now.a problem:
kubernetes-sigs/controller-runtime#934
With MultiNamespacedCacheBuilder, using the client, we're making a call to be able to get cluster platform(https://github.com/openshift/cloud-ingress-operator/blob/master/pkg/utils/infrastructure.go#L18-L22), which is a global resource, then we're seeing errors in the reconcile loop of the controllers because of that issue above:the issue above is Solved:
Using the same pattern used on unit tests of the package(dynamic client + unstructured.Unstructured):
https://github.com/kubernetes-sigs/controller-runtime/pull/1326/files#diff-3e99be25ef623d0bc22234a878bef63a1fef2029a18d5b35f9079537e9f59ebeR432-R441
Requirement:
Progress to the desired version
#177