pod-scaler: add labels to Build Pods via admission #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
stevekuznetsov
force-pushed
the
skuznets/build-pod-labeler
branch
2 times, most recently
from
b313c28
to
ea1799e
Compare
stevekuznetsov
force-pushed
the
skuznets/build-pod-labeler
branch
3 times, most recently
from
8a61d19
to
dadea75
Compare
...caler/testdata/zz_fixture_TestMutatePods_pod_associated_with_a_build_that_has_no_labels.yaml
Outdated
Show resolved
Hide resolved
openshift-ci-robot
added
do-not-merge/hold
|
/hold I want this: kubernetes-sigs/controller-runtime#1429 |
stevekuznetsov
force-pushed
the
skuznets/build-pod-labeler
branch
from
dadea75
to
9ab283a
Compare
stevekuznetsov
force-pushed
the
skuznets/build-pod-labeler
branch
2 times, most recently
from
928b215
to
3149ff2
Compare
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
stevekuznetsov
force-pushed
the
skuznets/build-pod-labeler
branch
from
3149ff2
to
3e31dbe
Compare
|
@petr-muller @alvaroaleman this is ready for review again now |
alvaroaleman
approved these changes
Apr 23, 2021
|
/retest |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
We need labels on Pods to associate individual executions with their semantic category. Today, we label Builds (as that's what we create) but the Build subsystem does not carry those labels forward to the Pods that implement the Build. This patch adds a new mutating admission webhook server that will add the labels where necessary. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
stevekuznetsov
force-pushed
the
skuznets/build-pod-labeler
branch
from
3e31dbe
to
9b9d2cb
Compare
|
lol |
openshift-ci-robot
removed
the
do-not-merge/hold
|
Part of DPTP-1822 |
alvaroaleman
approved these changes
Apr 23, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, petr-muller, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need labels on Pods to associate individual executions with their
semantic category. Today, we label Builds (as that's what we create) but
the Build subsystem does not carry those labels forward to the Pods that
implement the Build. This patch adds a new mutating admission webhook
server that will add the labels where necessary.
Signed-off-by: Steve Kuznetsov skuznets@redhat.com
/assign @petr-muller @alvaroaleman