Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump buildah to v1.16.7 and imagebuilder to v1.1.8 #183

Closed
wants to merge 1 commit into from
Closed

bump buildah to v1.16.7 and imagebuilder to v1.1.8 #183

wants to merge 1 commit into from

Conversation

nalind
Copy link
Member

@nalind nalind commented Oct 22, 2020 •
edited

Bump github.com/containers/buildah from v1.16.4 to v1.16.5, mainly to pick up containers/buildah#2688, github.com/containers/storage from v1.23.3 to v1.24.0 to pick up http://github.com/containers/storage/pull/755, and github.com/openshift/imagebuilder from v1.17 to v1.18, to pick up openshift/imagebuilder#177 and openshift/imagebuilder#170, and github.com/containers/image/v5 from v5.5.2 to v5.10.4, to pick up containers/image#1089 and containers/image#1138.

Among those, imagebuilder#170, adjusts our Dockerfile parser to match quoting changes that landed in docker build 17.06, which may affect compatibility with OpenShift 3.11.

Closes #219.

@rhatdan
Copy link
Contributor

rhatdan commented Oct 22, 2020

LGTM

@nalind
Copy link
Member Author

nalind commented Oct 23, 2020

/retest

@nalind
Copy link
Member Author

nalind commented Nov 30, 2020

Rebased and updated to incorporate containers/buildah#2769, containers/buildah#2768, and containers/buildah#2723.

/retitle bump buildah to v1.16.7 and imagebuilder to v1.1.8

@openshift-ci-robot openshift-ci-robot changed the title bump buildah to v1.16.5 and imagebuilder to v1.18 bump buildah to v1.16.7 and imagebuilder to v1.1.8 Nov 30, 2020
@nalind
Copy link
Member Author

nalind commented Dec 1, 2020

/retest

2 similar comments
@nalind
Copy link
Member Author

nalind commented Dec 1, 2020

/retest

@nalind
Copy link
Member Author

nalind commented Dec 3, 2020

/retest

@nalind
Copy link
Member Author

nalind commented Dec 7, 2020

Added a bump to github.com/containers/storage v1.24.0.

@rhatdan
Copy link
Contributor

rhatdan commented Dec 7, 2020

/approve

@rhatdan
Copy link
Contributor

rhatdan commented Dec 7, 2020

@gabemontero @coreydaley @adambkaplan @bparees @adambkaplan @smarterclayton PTAL

@nalind
Copy link
Member Author

nalind commented Feb 22, 2021

Rebased, now with an even newer version of containers/image.
/retest

@nalind nalind mentioned this pull request Feb 24, 2021
Closed
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 25, 2021
@nalind
bump buildah and imagebuilder
7396976 
Bump github.com/containers/buildah from v1.16.4 to v1.16.7,
github.com/openshift/imagebuilder from v1.1.7 to v1.1.8, and
github.com/containers/image/v5 from v5.5.2 to v5.10.4, and
github.com/containers/storage from v1.23.3 to v1.24.0.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 25, 2021
@nalind
Copy link
Member Author

nalind commented Feb 25, 2021

Rebased, moved to the newest release of containers/image.

@nalind
Copy link
Member Author

nalind commented Feb 25, 2021

/test e2e-aws-image-ecosystem

@rhatdan
Copy link
Contributor

rhatdan commented Feb 26, 2021

/approved
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nalind, rhatdan
To complete the pull request process, please assign smarterclayton after the PR has been reviewed.
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Contributor

rhatdan commented May 3, 2021

I am pretty sure this is done, should this PR be closed?

@nalind
Copy link
Member Author

nalind commented May 4, 2021

Yes, this is obsolete now. Closing.

@nalind nalind closed this May 4, 2021
@nalind nalind deleted the bump-buildah-1.16.5 branch May 4, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@gabemontero gabemontero Awaiting requested review from gabemontero

Assignees

@rhatdan rhatdan

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add latest containers/image with the „quay mirror fix“
3 participants
@nalind @rhatdan @openshift-ci-robot