-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-ISSUE: make dockerfile multi-arch compatible #754
base: master
Are you sure you want to change the base?
NO-ISSUE: make dockerfile multi-arch compatible #754
Conversation
@rccrdpccl: This pull request explicitly references no jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @adriengentil |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rccrdpccl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
eee0f22
to
125e258
Compare
Signed-off-by: Riccardo piccoli <rpiccoli@redhat.com>
125e258
to
2708f52
Compare
/test ? |
@adriengentil: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test edge-publish-multi-arch-images-dry-run |
let's use |
@rccrdpccl what did we decide to do here? |
sorry, I've totally lost track of this, I've created https://issues.redhat.com/browse/MGMT-16720 to keep track of it, will have a look soon because I totally forgot why I was doing this 😓 |
in the meantime... |
/retest |
@rccrdpccl: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
name=created by dnf config-manager from https://mirror.openshift.com/pub/openshift-v4/\$basearch/dependencies/rpms/${OCP_VERSION}/\n\ | ||
baseurl=https://mirror.openshift.com/pub/openshift-v4/\$basearch/dependencies/rpms/${OCP_VERSION}/\n\ | ||
enabled=1" > /etc/yum.repos.d/mirror.openshift.com_pub_openshift-v4_${TARGETPLATFORM}_dependencies_rpms_${OCP_VERSION}_.repo &&\ | ||
dnf install --nogpgcheck -y openshift-clients && dnf clean all && rm -rf /var/cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rccrdpccl I see that currently it cannot find https://mirror.openshift.com/pub/openshift-v4/ppc64le/dependencies/rpms/4.15-el8-beta/repodata/repomd.xml
and that's the reason it fails
I guess we have two other options:
- Copy the static binaries instead of rpm installation, e.g. https://mirror.openshift.com/pub/openshift-v4/ppc64le/clients/ocp/4.15.0-rc.0/
- Use an older version. I see that this one is available for ppc: https://mirror.openshift.com/pub/openshift-v4/ppc64le/dependencies/rpms/4.12-el8-beta/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the hint. I would avoid using binary if possible as it cannot be scanned by security scans, but I'll it take into account
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
cli image is not multiarch
security scans need rpm to validate oc binaries