Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: make dockerfile multi-arch compatible #754

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rccrdpccl
Copy link
Contributor

@rccrdpccl rccrdpccl commented Nov 24, 2023

cli image is not multiarch
security scans need rpm to validate oc binaries

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 24, 2023
@openshift-ci-robot
Copy link

@rccrdpccl: This pull request explicitly references no jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rccrdpccl
Copy link
Contributor Author

/cc @adriengentil

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 24, 2023
@openshift-ci openshift-ci bot added the downstream-change-needed Requires updating downstream image label Nov 24, 2023
Copy link

openshift-ci bot commented Nov 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rccrdpccl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2023
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.33%. Comparing base (f1bb876) to head (2708f52).
Report is 37 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #754   +/-   ##
=======================================
  Coverage   56.33%   56.33%           
=======================================
  Files          15       15           
  Lines        3220     3220           
=======================================
  Hits         1814     1814           
  Misses       1241     1241           
  Partials      165      165           

@rccrdpccl rccrdpccl force-pushed the make-multiarch-controller-dockerfile branch from eee0f22 to 125e258 Compare November 24, 2023 12:03
Signed-off-by: Riccardo piccoli <rpiccoli@redhat.com>
@rccrdpccl rccrdpccl force-pushed the make-multiarch-controller-dockerfile branch from 125e258 to 2708f52 Compare November 24, 2023 12:48
@adriengentil
Copy link
Contributor

/test ?

Copy link

openshift-ci bot commented Nov 24, 2023

@adriengentil: The following commands are available to trigger required jobs:

  • /test e2e-agent-compact-ipv4
  • /test edge-e2e-ai-operator-ztp
  • /test edge-e2e-metal-assisted
  • /test edge-format-check
  • /test edge-images
  • /test edge-lint
  • /test edge-unit-test
  • /test images
  • /test mce-images

The following commands are available to trigger optional jobs:

  • /test e2e-agent-ha-dualstack
  • /test e2e-agent-sno-ipv6
  • /test edge-e2e-metal-assisted-cnv
  • /test edge-e2e-metal-assisted-ipv6
  • /test edge-e2e-metal-assisted-lvm
  • /test edge-e2e-metal-assisted-odf
  • /test edge-e2e-metal-assisted-single-node
  • /test edge-e2e-oci-assisted
  • /test edge-e2e-oci-assisted-4-14
  • /test edge-publish-multi-arch-images-dry-run

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-assisted-installer-master-e2e-agent-compact-ipv4
  • pull-ci-openshift-assisted-installer-master-edge-e2e-ai-operator-ztp
  • pull-ci-openshift-assisted-installer-master-edge-e2e-metal-assisted
  • pull-ci-openshift-assisted-installer-master-edge-format-check
  • pull-ci-openshift-assisted-installer-master-edge-images
  • pull-ci-openshift-assisted-installer-master-edge-lint
  • pull-ci-openshift-assisted-installer-master-edge-unit-test
  • pull-ci-openshift-assisted-installer-master-images
  • pull-ci-openshift-assisted-installer-master-mce-images

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adriengentil
Copy link
Contributor

/test edge-publish-multi-arch-images-dry-run

@adriengentil
Copy link
Contributor

let's use registry.ci.openshift.org/openshift/release:golang-1.20 for the moment, and open a ticket to move to registry.access.redhat.com/ubi9/go-toolset here and in the other repos?

@osherdp
Copy link
Contributor

osherdp commented Jan 31, 2024

@rccrdpccl what did we decide to do here?

@rccrdpccl
Copy link
Contributor Author

sorry, I've totally lost track of this, I've created https://issues.redhat.com/browse/MGMT-16720 to keep track of it, will have a look soon because I totally forgot why I was doing this 😓

@rccrdpccl
Copy link
Contributor Author

in the meantime...
/retest

@osherdp
Copy link
Contributor

osherdp commented Feb 7, 2024

Status code: 404 for https://mirror.openshift.com/pub/openshift-v4/s390x/dependencies/rpms/4.15-el8-beta/repodata/repomd.xml (IP: 18.67.76.28)

/retest

Copy link

openshift-ci bot commented Feb 7, 2024

@rccrdpccl: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/edge-publish-multi-arch-images-dry-run 2708f52 link false /test edge-publish-multi-arch-images-dry-run

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

name=created by dnf config-manager from https://mirror.openshift.com/pub/openshift-v4/\$basearch/dependencies/rpms/${OCP_VERSION}/\n\
baseurl=https://mirror.openshift.com/pub/openshift-v4/\$basearch/dependencies/rpms/${OCP_VERSION}/\n\
enabled=1" > /etc/yum.repos.d/mirror.openshift.com_pub_openshift-v4_${TARGETPLATFORM}_dependencies_rpms_${OCP_VERSION}_.repo &&\
dnf install --nogpgcheck -y openshift-clients && dnf clean all && rm -rf /var/cache
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rccrdpccl I see that currently it cannot find https://mirror.openshift.com/pub/openshift-v4/ppc64le/dependencies/rpms/4.15-el8-beta/repodata/repomd.xml and that's the reason it fails

I guess we have two other options:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hint. I would avoid using binary if possible as it cannot be scanned by security scans, but I'll it take into account

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. downstream-change-needed Requires updating downstream image jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants