OpenShiftControllerManagerConfig: add serviceAccountSigningPublicKeyFile #1893
Conversation
|
Hello @sanchezl! Some important instructions when contributing to openshift/api: |
sanchezl
changed the title
sanchezl
changed the title
openshift-ci
bot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sanchezl The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| // serviceAccountSigningPublicKeyFile specifies the path to a file that contains the current public key of the | ||
| // service account token issuer. The issuer signs issued ID tokens with this private key. | ||
| // +optional | ||
| ServiceAccountSigningPublicKeyFile string `json:"serviceAccountSigningPublicKeyFile,omitempty"` |
There was a problem hiding this comment.
What happens when this is omitted?
Does this interact with any other fields nearby?
Is there a format for this? Any characters not allowed?
How long can this be? Infinitely?
I would expect to see each of the above documented in the godoc, and where appropriate validated
There was a problem hiding this comment.
@JoelSpeed I've updated the doc with the omission info, but as to the questions related to validation, I do not think any further validation is appropriate for a field meant to contain a file name. Beyond, the complexity of coming up with a format that could encompass every valid file name, even a "valid" file name can be wrong if the file does not exist. I see no other validation of file name value fields in this repo.
There was a problem hiding this comment.
We should at least impose a maximal length to the string, 4096 I think would be reasonable, it's the maximum path length on most Unix based systems
openshift-ci
bot
added
size/S
|
@sanchezl: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
OCM needs access to the service account bound API token signing public key. On standalone, the crypto materials are available in a secret. On Hypershift, the secret is not made available to the hosted clusters. KCM has a similar requirement, which hypershift satisfies by projecting the secret into a volume on the KCM pod and then specifying the appropriate file name via a cli parameter. OCM is completey configured via a config file. This PR adds the serviceAccountSigningPublicKeyFile field to the OCM config file.