Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-1783: Promote ValidatingAdmissionPolicy to GA #1888

Merged
merged 1 commit into from
May 18, 2024

Conversation

dinhxuanvu
Copy link
Member

Set ValidatingAdmissionPolicy feature to be enabled by default

Set ValidatingAdmissionPolicy feature to be enabled by default

Signed-off-by: Vu Dinh <vudinh@outlook.com>
Copy link
Contributor

openshift-ci bot commented May 13, 2024

Hello @dinhxuanvu! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@dinhxuanvu
Copy link
Member Author

dinhxuanvu commented May 13, 2024

Hold until after branching
@soltysh FYI
/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 13, 2024
@soltysh
Copy link
Member

soltysh commented May 17, 2024

/test e2e-aws-serial

Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@soltysh soltysh changed the title Promote ValidatingAdmissionPolicy to GA API-1783: Promote ValidatingAdmissionPolicy to GA May 17, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 17, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 17, 2024

@dinhxuanvu: This pull request references API-1783 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.16." or "openshift-4.16.", but it targets "openshift-4.17" instead.

In response to this:

Set ValidatingAdmissionPolicy feature to be enabled by default

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2024
@soltysh
Copy link
Member

soltysh commented May 17, 2024

/override ci/prow/verify
this is needed for k8s 1.30 bump

Copy link
Contributor

openshift-ci bot commented May 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh
Copy link
Member

soltysh commented May 17, 2024

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. labels May 17, 2024
Copy link
Contributor

openshift-ci bot commented May 17, 2024

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/verify

In response to this:

/override ci/prow/verify
this is needed for k8s 1.30 bump

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@soltysh
Copy link
Member

soltysh commented May 17, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 17, 2024
@soltysh
Copy link
Member

soltysh commented May 17, 2024

/override ci/prow/e2e-aws-ovn-hypershift
this is being tracked in https://issues.redhat.com/browse/TRT-1672

Copy link
Contributor

openshift-ci bot commented May 17, 2024

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/e2e-aws-ovn-hypershift

In response to this:

/override ci/prow/e2e-aws-ovn-hypershift
this is being tracked in https://issues.redhat.com/browse/TRT-1672

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 931fa98 and 2 for PR HEAD d26b940 in total

@soltysh
Copy link
Member

soltysh commented May 17, 2024

/test e2e-aws-serial-techpreview

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6a02854 and 1 for PR HEAD d26b940 in total

@dinhxuanvu
Copy link
Member Author

/override ci/prow/e2e-aws-ovn-hypershift
/override ci/prow/verify

Copy link
Contributor

openshift-ci bot commented May 17, 2024

@dinhxuanvu: dinhxuanvu unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers.

In response to this:

/override ci/prow/e2e-aws-ovn-hypershift
/override ci/prow/verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@soltysh
Copy link
Member

soltysh commented May 18, 2024

/override ci/prow/verify

Copy link
Contributor

openshift-ci bot commented May 18, 2024

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/verify

In response to this:

/override ci/prow/verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@soltysh
Copy link
Member

soltysh commented May 18, 2024

/override ci/prow/e2e-aws-ovn-hypershift

Copy link
Contributor

openshift-ci bot commented May 18, 2024

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/e2e-aws-ovn-hypershift

In response to this:

/override ci/prow/e2e-aws-ovn-hypershift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented May 18, 2024

@dinhxuanvu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 280767a into openshift:master May 18, 2024
18 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.17.0-202405180810.p0.g280767a.assembly.stream.el9 for distgit ose-cluster-config-api.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants