-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDN-4545: [Release 4-15] Add transit switch config to 4.15 #1872
base: release-4.15
Are you sure you want to change the base?
Conversation
"Backport" of openshift#1626 The CEL validations used here are not available in 4.15 so we have to use regex to validate the fields Signed-off-by: Benjamin Pickard <bpickard@redhat.com>
@bpickard22: This pull request references SDN-4545 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.z" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Hello @bpickard22! Some important instructions when contributing to openshift/api: |
/jira refresh |
@bpickard22: This pull request references SDN-4545 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@bpickard22: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@JoelSpeed @trozet PTAL |
Validation and structure looks good now. Do we have the relevant QE testing done for the master branch feature? Are we happy that we can backport the feature without introducing any regressions in 4.15? Have you got ack from a staff eng and your PM for the backport as well? |
I grant it Staff Engineer ACK, and PM (Marc Curry) has approved this backport too. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bpickard22, knobunc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@JoelSpeed relevant testing is done on master and I will ask qe to run regression tests once the cno pr is up |
Can the CNO PR not go up prior to this merging? Would that not allow complete testing before we merge anything into the backported branch? |
This is a test commit with unmerged API changes for transit and join switch CIDR. Ref: openshift/api#1872 Change log: - API bump in release-4.15 branch $ go mod edit -replace github.com/openshift/api=github.com/bpickard22/api@4.15-switch-config $ go mod tidy $ go mod vendor - Made minor change to update-codegen.sh to not use controller-gen version v0.15.0 and use v0.14.0 instead. v0.15.0 needs go version 1.22 and currently we use lower version than that. - Ran update-codegen.sh to recreatefiles in manifests directory. Signed-off-by: Arnab Ghosh <arnabghosh89@gmail.com>
@JoelSpeed cno pr is up and i have asked qe team to run regression tests, will ping you again once that is done |
/label qe-approved QE regression looks good |
@bpickard22: This pull request references SDN-4545 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Where are we at on this? I see QE approved, is the implementation good to go? Have the team reviewed it and are happy to merge? |
just waiting on an approver from my team to apply the needed labels then this should merge @JoelSpeed |
/label backport-risk-assessed |
@trozet: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-staff-engineers] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@JoelSpeed can you add the necessary labels here. we have staff approval, qe approval, and my team is good with this but does not have the perms to give the labels |
/label backport-risk-assessed |
/jira refresh |
@bpickard22: This pull request references SDN-4545 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/tide refresh |
/label cherry-pick-approved |
/jira refresh |
@wangke19: This pull request references SDN-4545 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@zshi-redhat: This pull request references SDN-4545 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@bpickard22: This pull request references SDN-4545 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
"Backport" of #1626
The CEL validations used here are not available in 4.15 so we have to use regex to validate the fields