ETCD-488: Move etcd hardware speed feature to GA

[dusk125]

No description provided.

[openshift-ci]

Hello @dusk125! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[tjungblu]

/hold

waiting for apiserver confirmation the retry configs are reflected

[dusk125]

/assign @tkashem

[deads2k]

/test all

[deads2k]

Can you either

1. link to the automated tests results in periodic jobs running on a schedule to ensure regression protection both from the owning component and other components via side-effect (cluster-node-tuning-operator just benefited from such protection when an MCO PR broke them)

2. A direct QE sign off that this feature is ready.
   

See deeper examples of how to be promoted here: https://github.com/openshift/enhancements/blob/master/dev-guide/featuresets.md#id-like-to-declare-a-feature-accessible-by-default--what-is-the-process

[soltysh]

This is waiting for openshift/origin#28726

[dusk125]

/hold
for openshift/origin#28726

[dusk125]

/unhold e2e test has been added

[dusk125]

/hold cancel

[soltysh]

/retest

[openshift-ci-robot]

@dusk125: This pull request references ETCD-488 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[dusk125]

/retest

[soltysh]

/override ci/prow/verify
/lgtm

[openshift-ci]

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/verify

In response to this:

/override ci/prow/verify
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dusk125, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[soltysh]

/test e2e-aws-ovn-hypershift

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 931fa98 and 2 for PR HEAD 4a01715 in total

[soltysh]

/hold

[soltysh]

/hold cancel
/retest

[dusk125]

/cherry-pick release-4.16

[openshift-cherrypick-robot]

@dusk125: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[soltysh]

/override ci/prow/verify

[openshift-ci]

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/verify

In response to this:

/override ci/prow/verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[soltysh]

/retest-required

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 280767a and 1 for PR HEAD 4a01715 in total

[soltysh]

/retest-required

[geliu2016]

Hello @soltysh , I saw you just retest this pr, I'm not sure whether we may start pre-merge test, because I just try to test it with 4.16.0-0.ci.test-2024-05-21-041439-ci-ln-vjhzitb-latest, but the this feature not ready yet.

$ oc get clusterversion
NAME VERSION AVAILABLE PROGRESSING SINCE STATUS
version 4.16.0-0.ci.test-2024-05-21-041439-ci-ln-vjhzitb-latest True False 38m Cluster version is 4.16.0-0.ci.test-2024-05-21-041439-ci-ln-vjhzitb-latest
$ oc patch etcd/cluster --type=merge -p '{"spec": {"controlPlaneHardwareSpeed": "Slower"}}'
Warning: unknown field "spec.controlPlaneHardwareSpeed"
etcd.operator.openshift.io/cluster patched (no change)

[openshift-ci]

@dusk125: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-cherrypick-robot]

@dusk125: new pull request created: #1901

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.17.0-202405210943.p0.ge278985.assembly.stream.el9 for distgit ose-cluster-config-api.
All builds following this will include this PR.