Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-16418: Show more clear info about the DeploymentConfig is deprecated #1837

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OCPBUGS-16418: Show more clear info about the DeploymentConfig is deprecated #1837

wants to merge 1 commit into from

Conversation

sanchezl
Copy link
Contributor

@sanchezl sanchezl commented Mar 27, 2024 •
edited

  • Updated deprecated from OCP 4.14 to the corresponding k8s 1.27
  • Because this API is currently never going away, set removed=0.0

With these settings the warning header should change from this:

apps.openshift.io/v1 DeploymentConfig is deprecated in v4.14+, unavailable in v4.10

to

apps.openshift.io/v1 DeploymentConfig is deprecated in v1.27+

Open question:

Given that this type is never actually going to be removed, should we just remove the deprecation warning?
Marking it as deprecated, usually starts the clock towards removal.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 27, 2024

Hello @sanchezl! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 27, 2024
@openshift-ci openshift-ci bot requested review from mfojtik and soltysh March 27, 2024 18:38
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sanchezl
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sanchezl sanchezl changed the title deploymentconfig replace ocp versions with k8s versions Mar 28, 2024
@sanchezl
Copy link
Contributor Author

sanchezl commented Mar 28, 2024 •
edited

Proof PR: openshift/kubernetes#1921

@sanchezl sanchezl changed the title replace ocp versions with k8s versions OCPBUGS-16418: Show more clear info about the DeploymentConfig is deprecated Mar 28, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 28, 2024
@openshift-ci-robot
Copy link

@sanchezl: This pull request references Jira Issue OCPBUGS-16418, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

  • replace ocp versions with k8s versions
  • update generated code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. label May 16, 2024
@openshift-ci-robot
Copy link

@sanchezl: This pull request references Jira Issue OCPBUGS-16418, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

  • Updated deprecated from OCP 4.14 to the corresponding k8s 1.27
  • Because this API is currently never going away, set removed=0.0

With these settings the warning header should change from this:

apps.openshift.io/v1 DeploymentConfig is deprecated in v4.14+, unavailable in v4.10

to

apps.openshift.io/v1 DeploymentConfig is deprecated in v1.27+

Open question:

Given that this type is never actually going to be removed, should we just remove the deprecation warning?
Marking it as deprecated, usually starts the clock towards removal.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 16, 2024

@sanchezl: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sanchezl
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@sanchezl: This pull request references Jira Issue OCPBUGS-16418, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sanchezl
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 17, 2024
@openshift-ci-robot
Copy link

@sanchezl: This pull request references Jira Issue OCPBUGS-16418, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from zhouying7780 May 17, 2024 13:16
ingvagabund
ingvagabund reviewed Jun 3, 2024
View reviewed changes
apps/v1/types.go
// +k8s:prerelease-lifecycle-gen:deprecated=4.14
// +k8s:prerelease-lifecycle-gen:removed=4.10000
// +k8s:prerelease-lifecycle-gen:introduced=1.1
// +k8s:prerelease-lifecycle-gen:deprecated=1.27
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: the versioning was originally intentionally set to follow the openshift versioning

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, but we are making use of upstream functionality that only truly understands kubernetes versions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DCs is an OpenShift resource. It's kinda strange to claim an OpenShift resources was deprecated in Kubernetes.

ingvagabund
ingvagabund reviewed Jun 3, 2024
View reviewed changes
apps/v1/types.go
// +k8s:prerelease-lifecycle-gen:removed=4.10000
// +k8s:prerelease-lifecycle-gen:introduced=1.1
// +k8s:prerelease-lifecycle-gen:deprecated=1.27
// +k8s:prerelease-lifecycle-gen:removed=0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, if this removes the removed part in the message => ++

@ingvagabund
Copy link
Member

Given that this type is never actually going to be removed, should we just remove the deprecation warning?

The warning message is definitely annoying. +1 for removing it when listing all resources. I'd still prefer to keep it when CRUD'ing the DC resource.

@sanchezl
Copy link
Contributor Author

sanchezl commented Jun 3, 2024 •
edited

Given that this type is never actually going to be removed, should we just remove the deprecation warning?

The warning message is definitely annoying. +1 for removing it when listing all resources. I'd still prefer to keep it when CRUD'ing the DC resource.

@ingvagabund I've opened a companion PR to remove the message completely from oc status and oc get all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ingvagabund ingvagabund ingvagabund left review comments

@mfojtik mfojtik Awaiting requested review from mfojtik

@soltysh soltysh Awaiting requested review from soltysh

@zhouying7780 zhouying7780 Awaiting requested review from zhouying7780

Assignees
No one assigned
Labels
jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sanchezl @openshift-ci-robot @ingvagabund