Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API-1783: bump(k8s): update k8s to v1.30 #1813

Merged
merged 3 commits into from
May 21, 2024
Merged

API-1783: bump(k8s): update k8s to v1.30 #1813

merged 3 commits into from
May 21, 2024

Conversation

dinhxuanvu
Copy link
Member

No description provided.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 15, 2024

Hello @dinhxuanvu! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@dinhxuanvu dinhxuanvu changed the title bump(k8s): update k8s to v1.30 [WIP] bump(k8s): update k8s to v1.30 Mar 15, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 15, 2024
@dinhxuanvu
Copy link
Member Author

The PR is rebased on 1.30 beta release at the monent.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 15, 2024
@openshift-ci openshift-ci bot requested review from bparees and soltysh March 15, 2024 17:45
@dinhxuanvu
Copy link
Member Author

dinhxuanvu commented Mar 28, 2024 •
edited

Updated to 1.30.0-rc.0
Will squash commits later. For now, keeping separate commits for review purposes.

@dinhxuanvu dinhxuanvu force-pushed the rebase-1.30 branch 6 times, most recently from 4fec32e to 2d5b268 Compare April 17, 2024 16:07
@soltysh
Copy link
Member

soltysh commented Apr 17, 2024

/test unit

@soltysh
Copy link
Member

soltysh commented Apr 18, 2024

/test unit

1 similar comment
@hongkailiu
Copy link
Member

/test unit

@dinhxuanvu dinhxuanvu changed the title [WIP] bump(k8s): update k8s to v1.30 bump(k8s): update k8s to v1.30 Apr 18, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 18, 2024
@dinhxuanvu dinhxuanvu force-pushed the rebase-1.30 branch 2 times, most recently from 3f13d95 to cdf4fdc Compare April 19, 2024 03:17
@soltysh
Copy link
Member

soltysh commented Apr 19, 2024

/hold
this should not merge into 4.16 accidentally

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2024
@dinhxuanvu
bump(k8s): bump k8s version to v1.30
1f664b3 
Signed-off-by: Vu Dinh <vudinh@outlook.com>
@dinhxuanvu
make update
b0ba710 
Signed-off-by: Vu Dinh <vudinh@outlook.com>
@dinhxuanvu
Update go builder image to 1.22
7e26fc0 
Signed-off-by: Vu Dinh <vudinh@outlook.com>
@soltysh soltysh changed the title bump(k8s): update k8s to v1.30 API-1783: bump(k8s): update k8s to v1.30 May 21, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 21, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 21, 2024 •
edited by openshift-ci bot

@dinhxuanvu: This pull request references API-1783 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@soltysh
Copy link
Member

soltysh commented May 21, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2024
@soltysh
Copy link
Member

soltysh commented May 21, 2024

/retest-required

soltysh
soltysh approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label May 21, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
@soltysh
Copy link
Member

soltysh commented May 21, 2024

/test e2e-aws-ovn-techpreview

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 21, 2024

@dinhxuanvu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 0314f31 into openshift:master May 21, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@bparees bparees Awaiting requested review from bparees

Assignees

@soltysh soltysh

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dinhxuanvu @soltysh @hongkailiu @openshift-ci-robot