Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to google-go v42 #420

Merged
merged 1 commit into from Feb 21, 2022
Merged

Update to google-go v42 #420

merged 1 commit into from Feb 21, 2022

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented Feb 18, 2022

ghinstallation still depends on v41 so need to keep it for now until
bradleyfalzon/ghinstallation#62 get merged.

Signed-off-by: Chmouel Boudjnah chmouel@redhat.com

Changes

Submitter Checklist

  • ♽ Run make test lint before submitting a PR (ie: via pre-push github hook no need to waste CPU cycle on CI
  • 📖 If you are adding a user facing feature or make a change of the behavior, please make sure to document it
  • 🧪 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
  • 🎁 If that's something that is possible to do please make sure to check if we can add a e2e test.
  • 🔎 If there is a flakiness in the CI tests then make sure to get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it.

See the developer guide for a bit more details.

ghinstallation still depends on v41 so need to keep it for now until
bradleyfalzon/ghinstallation#62 get merged.

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
@codecov-commenter
Copy link

Codecov Report

Merging #420 (e517b2e) into main (c708f33) will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #420      +/-   ##
==========================================
- Coverage   70.68%   70.47%   -0.22%     
==========================================
  Files          50       50              
  Lines        2627     2625       -2     
==========================================
- Hits         1857     1850       -7     
- Misses        585      589       +4     
- Partials      185      186       +1     
Impacted Files Coverage Δ
pkg/cmd/tknpac/repository/describe.go 61.76% <ø> (ø)
pkg/pipelineascode/status.go 82.22% <ø> (ø)
pkg/provider/github/acl.go 81.72% <ø> (ø)
pkg/provider/github/events.go 95.62% <ø> (ø)
pkg/provider/github/github.go 82.79% <ø> (ø)
pkg/provider/github/status.go 88.76% <ø> (ø)
pkg/sort/pipelinerun.go 63.63% <0.00%> (-22.08%) ⬇️
pkg/resolve/resolve.go 87.91% <0.00%> (-0.98%) ⬇️
pkg/consoleui/openshift.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c708f33...e517b2e. Read the comment docs.

@chmouel chmouel merged commit 26c7f19 into openshift-pipelines:main Feb 21, 2022
@chmouel chmouel deleted the v42 branch February 21, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants