trt-1204: option to save job run identifier json #2
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@neisw: This pull request references trt-1204 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neisw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
| @@ -55,7 +63,7 @@ var cmd = &cobra.Command{ | |||
| for _, envVar := range opts.envVariables { | |||
| splitVar := strings.SplitN(envVar, "=", 2) | |||
| if len(splitVar) != 2 { | |||
| cmd.Usage() //nolint | |||
| cmd.Usage() // nolint | |||
There was a problem hiding this comment.
The lack of space is intentional golangci/golangci-lint#3109 (comment)
There was a problem hiding this comment.
Although lint seems to pass with the space, not sure why, but directive format in go is // followed by the directive directly without whitespace.
There was a problem hiding this comment.
Yeah, the change wasn't intentional on my part. But goland is pretty intentional about it...
There was a problem hiding this comment.
Weird, golang doesn't touch it for me.
There was a problem hiding this comment.
Are you using a go locally less than 1.19?
There was a problem hiding this comment.
go version go1.20 linux/amd64
There was a problem hiding this comment.
I can turn Reformat on save off
There was a problem hiding this comment.
I swear lint was failing with the space when I changed it, but if it's passing now we can fix it again if it becomes a problem
|
/lgtm |
Adds option to save JobRunIdentifier JSON for further job analysis