Vexflow migration 4.0.0 (old packages) #1085
Conversation
|
Hi Simon, I have reverted to the old packages as there were some issues with the new ones and as you said, let us keep the issues separated. |
|
This integration is complete with all checks passed! |
|
@sschmidTU I would say that there is some problem with ties, can you have a look at the demo? Thanks |
|
As said in #1083, please remove all the refactors that change the return type from Node to void. |
I made that because I saw that svg was returning Node and canvas undefined and I thought that if it works with undefined it was better to unify.
I took out the packages changes based on your comment and also based on the fact that I awas getting the same error as in #1059: ✖ multiple instances |
|
Please confirm if you still want the Node change reverted and if this is the case, I will do it. |
Canvas can't return a node because it doesn't have a DOM.
Yes, please revert it. |
|
Done |
| } | ||
| this.CanvasRenderingCtx.globalAlpha = alpha; | ||
| this.ctx.fillRect(rectangle.x, rectangle.y, rectangle.width, rectangle.height); | ||
| this.CanvasRenderingCtx.fillStyle = old; | ||
| this.CanvasRenderingCtx.globalAlpha = 1; | ||
| return undefined; // can't return dom node like with SVG | ||
| return undefined; // can't return svg dom node |
There was a problem hiding this comment.
please revert this comment change. the previous one is clearer. of course you can't return an svg node in canvas.
There was a problem hiding this comment.
Only this instance or make the same comment on the other instances within CanvasVexFlowBackend? They should all be the same within this file, should not them?
There was a problem hiding this comment.
Ok I will unify to the clearer one
|
It looks like Github is having some issues with comments on PRs, i can't reply to some of them anymore at some point, and sometimes it shows the comment belonging to the wrong code line. Responding to: edit: now i see it in your latest commit, it's good to revert them all, thank you! |
rvilarl
force-pushed
the
vexflowOldPackage
branch
from
86f641b
to
21c344a
Compare
No description provided.