Fix linter issues and clean up unused param

[jsturtevant]

Signed-off-by: James Sturtevant jstur@microsoft.com

Description:
The PRs started to fail when CI golangci-lint was bumped to 1.48.0: https://github.com/golangci/golangci-lint/releases

This fixes the linter issues and also cleans up an unused parameter

Testing done:

Affected area:

Functional Area
New Functionality	[ ]
CI System	[x]
CLI Tool	[ ]
Certificate Management	[ ]
Control Plane	[ ]
Demo	[ ]
Documentation	[ ]
Egress	[ ]
Ingress	[ ]
Install	[ ]
Networking	[ ]
Observability	[ ]
Performance	[ ]
SMI Policy	[ ]
Security	[ ]
Sidecar Injection	[ ]
Tests	[ ]
Upgrade	[ ]
Other	[x]

Please answer the following questions with yes/no.

1. Does this change contain code from or inspired by another project?

   • Did you notify the maintainers and provide attribution?

2. Is this a breaking change?

3. Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?

[codecov-commenter]

Codecov Report

Merging #4969 (6800b29) into main (8181675) will decrease coverage by 0.24%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #4969      +/-   ##
==========================================
- Coverage   68.58%   68.34%   -0.25%     
==========================================
  Files         221      220       -1     
  Lines       16014    15998      -16     
==========================================
- Hits        10984    10934      -50     
- Misses       4978     5012      +34     
  Partials       52       52              

Flag	Coverage Δ
unittests	68.34% <50.00%> (-0.25%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
cmd/cli/env.go	46.66% <ø> (ø)
cmd/cli/install.go	72.52% <ø> (ø)
cmd/osm-bootstrap/osm-bootstrap.go	46.25% <0.00%> (ø)
pkg/catalog/inbound_traffic_policies.go	92.49% <ø> (ø)
pkg/catalog/outbound_traffic_policies.go	92.74% <ø> (ø)
pkg/cli/environment.go	71.66% <ø> (ø)
pkg/envoy/rds/route/route_config.go	92.39% <ø> (ø)
pkg/trafficpolicy/trafficpolicy.go	96.15% <ø> (ø)
pkg/crdconversion/crdconversion.go	88.46% <100.00%> (ø)
pkg/certificate/manager.go	76.67% <0.00%> (-1.19%)	⬇️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[jsturtevant]

looks like this was golangci/golangci-lint#3002 in prep for go 1.19