Address code review feedback

Signed-off-by: Craig Perkins <cwperx@amazon.com>
opensearch-project · May 1, 2023 · 54d057c · 54d057c
1 parent 15c82db
commit 54d057c
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 18 deletions.
diff --git a/src/main/java/org/opensearch/sdk/ExtensionSettings.java b/src/main/java/org/opensearch/sdk/ExtensionSettings.java
@@ -97,23 +97,15 @@ private ExtensionSettings() {
      * @param hostPort  The port to bind this extension to.
      * @param opensearchAddress  The IP Address on which OpenSearch is running.
      * @param opensearchPort  The port on which OpenSearch is running.
-     * @param securitySettings A generic map of any settings set in the config file that are not default setting keys
      */
-    public ExtensionSettings(
-        String extensionName,
-        String hostAddress,
-        String hostPort,
-        String opensearchAddress,
-        String opensearchPort,
-        Map<String, String> securitySettings
-    ) {
+    public ExtensionSettings(String extensionName, String hostAddress, String hostPort, String opensearchAddress, String opensearchPort) {
         super();
         this.extensionName = extensionName;
         this.hostAddress = hostAddress;
         this.hostPort = hostPort;
         this.opensearchAddress = opensearchAddress;
         this.opensearchPort = opensearchPort;
-        this.securitySettings = securitySettings;
+        this.securitySettings = Map.of();
     }
 
     /**
@@ -124,15 +116,18 @@ public ExtensionSettings(
      * @param hostPort  The port to bind this extension to.
      * @param opensearchAddress  The IP Address on which OpenSearch is running.
      * @param opensearchPort  The port on which OpenSearch is running.
+     * @param securitySettings A generic map of any settings set in the config file that are not default setting keys
      */
-    public ExtensionSettings(String extensionName, String hostAddress, String hostPort, String opensearchAddress, String opensearchPort) {
-        super();
-        this.extensionName = extensionName;
-        this.hostAddress = hostAddress;
-        this.hostPort = hostPort;
-        this.opensearchAddress = opensearchAddress;
-        this.opensearchPort = opensearchPort;
-        this.securitySettings = Map.of();
+    public ExtensionSettings(
+        String extensionName,
+        String hostAddress,
+        String hostPort,
+        String opensearchAddress,
+        String opensearchPort,
+        Map<String, String> securitySettings
+    ) {
+        this(extensionName, hostAddress, hostPort, opensearchAddress, opensearchPort);
+        this.securitySettings = securitySettings;
     }
 
     public String getExtensionName() {

diff --git a/src/main/java/org/opensearch/sdk/ExtensionsRunner.java b/src/main/java/org/opensearch/sdk/ExtensionsRunner.java
@@ -191,6 +191,8 @@ protected ExtensionsRunner(Extension extension) throws IOException {
                 addSettingsToBuilder(settingsBuilder, settingsKey, extensionSettings);
             }
         }
+        String sslText = sslEnabled ? "enabled" : "disabled";
+        logger.info("SSL is " + sslText + " for transport");
         this.settings = settingsBuilder.build();
 
         final List<ExecutorBuilder<?>> executorBuilders = extension.getExecutorBuilders(settings);