Adding support for AWS SDK V2 request signer #116
Conversation
|
@matelang Thanks for creating PR. Will review your PR this week. |
|
Thanks @VijayanB for taking a look and for allowing the Actions to run. I can see that most tests pass, with the exception of the integration tests on version 2. Wondering whether it is something I missed or the test is flaky since it seems to be an HTTP connection issue? I can try and reproduce it locally as well. |
|
For tracking, I've opened an Issue and PR on AWS SDK with the fix from the second commit: |
Thank you @matelang! Retrying the CI |
|
According to their documentation: I believe opensearch-go supports from go 1.11. Should we update this as well? |
You are right. Sorry, I've missed it. I've added a new commit to address this: |
matelang
force-pushed
the
main
branch
2 times, most recently
from
a032cde
to
f6eea97
Compare
|
I've also fetched upstream and adapted the import path of the signer accordingly (appended v2 to import path). |
|
@matelang Looks like one of the commits has a sign off missing. Can you please fix it? |
@VachaShah I think it was the merge commit, I've fixed it by squashing all the work into just 1 commit. Have not changed anything else. |
|
@matelang Thanks for adding v2 support. Unfortunately i don't know way of writing integration test for aws iam feature. Did you get chance to test v2 support manually from opensearch-go? |
We already use the vendored version of the signer in production, so far it is working great for us. |
* Also raises minimum go version to 1.15 * Updates dependencies Signed-off-by: Máté Lang <langmatelaszlo@gmail.com>
|
Is there anything else I can do to get this merged in? |
|
Hi @matelang, can you please create an issue for the same and link this PR so it is easier to track? Also, it would be great if we can add this to the USER_GUIDE. |
Created the issue and linked it here. I will open another PR later today modifying the User guide accordingly. |
* Also raises minimum go version to 1.15 * Updates dependencies Signed-off-by: Máté Lang <langmatelaszlo@gmail.com> (cherry picked from commit f4a0b24)
|
@VachaShah added example and enhanced docs: |
* Also raises minimum go version to 1.15 * Updates dependencies Signed-off-by: Máté Lang <langmatelaszlo@gmail.com>
|
@matelang Do you know if this works for chunked gzipped requests? Care to try? Coming from opensearch-project/opensearch-py#176 and acm19/aws-request-signing-apache-interceptor#20 |
I have not tested it explicitly to be honest. We are using the default configurations for our OpenSearch client connection. I can try to reproduce it sometime time this week. Thanks for letting me know. |
Description
This PR introduces support for a new package that allows to use the new AWS SDK V2 to sign the OpenSearch Go client's HTTP request messages according to the AWS Signature spec V4 .
I've also updated all project dependencies to latest versions for bonus maintenance.
Issues Resolved
No issues found in tracker relating to this.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.