Add .lycheeignore and changelogs/fragments to workflow ignore #6795
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sean Li <lnse@amazon.com>
sejli
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba and
zhyuanqi
as code owners
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "chore". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6795 +/- ##
=======================================
Coverage 67.42% 67.42%
=======================================
Files 3444 3444
Lines 67781 67781
Branches 11023 11023
=======================================
+ Hits 45702 45704 +2
+ Misses 19413 19412 -1
+ Partials 2666 2665 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
manasvinibs
reviewed
May 20, 2024
|
Hi @sejli , are we targeting to get this PR into 2.15? |
Signed-off-by: Sean Li <lnse@amazon.com>
|
Hi @BionIT, this PR should be targeting |
Could you address the comments from @manasvinibs ? |
manasvinibs
approved these changes
Jun 5, 2024
BionIT
approved these changes
Jun 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
* adding new paths to ignore Signed-off-by: Sean Li <lnse@amazon.com> * adding new paths to push trigger Signed-off-by: Sean Li <lnse@amazon.com> --------- Signed-off-by: Sean Li <lnse@amazon.com> (cherry picked from commit f51f652) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zhyuanqi
pushed a commit
that referenced
this pull request
Jun 5, 2024
* adding new paths to ignore Signed-off-by: Sean Li <lnse@amazon.com> * adding new paths to push trigger Signed-off-by: Sean Li <lnse@amazon.com> --------- Signed-off-by: Sean Li <lnse@amazon.com> (cherry picked from commit f51f652) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
BionIT
pushed a commit
that referenced
this pull request
Jun 5, 2024
…#6930) * adding new paths to ignore * adding new paths to push trigger --------- (cherry picked from commit f51f652) Signed-off-by: Sean Li <lnse@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ananzh
added
the
Skip-Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
.lycheeignoreandchangelogs/fragments/**to skipbuild_and_testandcypressworkflows.Issues Resolved
#6772
Screenshot
N/A
Testing the changes
N/A
Changelog
Check List
yarn test:jestyarn test:jest_integration