[Backport 2.x] [saved objects] enable deletion of saved objects by type if configured #6716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
opensearch-trigger-bot
bot
added
autocut
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT and
xinruiba
as code owners
ZilongX
previously approved these changes
May 5, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6716 +/- ##
==========================================
- Coverage 67.42% 67.42% -0.01%
==========================================
Files 3442 3442
Lines 67802 67821 +19
Branches 11018 11022 +4
==========================================
+ Hits 45716 45726 +10
- Misses 19420 19427 +7
- Partials 2666 2668 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
ciGroup3 fails on src/plugins/dashboard/public/application/components/dashboard_listing/dashboard_listing.test.tsx, which seems flaky. This PR has no change on dashboard. Also the snapshot update is not valid. Local can't reproduce. |
ananzh
previously approved these changes
May 5, 2024
#6443) * [saved objects] enable deletion of saved objects by type if configured Adds the following settings: ``` migrations.delete.enabled migrations.delete.types ``` `unknown` types already exist but the purpose of this type is for plugins that are disabled. OpenSearch Dashboards gets confused when a plugin is not defining a saved object type but the saved object exists. This can occur when migrating from a non-OSD version and there exists non-compatiable saved objects. If OSD is failing to migrate an index because of a document, I can now configure OSD to delete types of saved objects that I specified because I know that these types should not be carried over. resolves: #1040 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * address comments Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Changeset file for PR #6443 created/updated --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 7a8c281) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kavilla
force-pushed
the
backport/backport-6443-to-2.x
branch
from
7d32df1
to
e676653
Compare
kavilla
previously approved these changes
May 7, 2024
abbyhu2000
previously approved these changes
May 14, 2024
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
|
Update branch and re-trigger all checks now |
ZilongX
approved these changes
May 28, 2024
xinruiba
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 7a8c281 from #6443.