Refactor updateBundleLimits to categorize and sort limits
#6504
Conversation
This commit updates the `updateBundleLimits` function to categorize plugin limits into 'External Plugins' and 'OpenSearch Dashboards Plugins'. Each category is now sorted by size in descending order. This categorization and sorting are aimed at improving the clarity and manageability of the page load asset size limits. Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ℹ️ Manual Changeset Creation ReminderPlease ensure manual commit for changeset file 6504.yml under folder changelogs/fragments to complete this PR. If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link. For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool. |
|
|
||
| const newLimits: SortedLimits = { | ||
| pageLoadAssetSize: { | ||
| 'External Plugins': externalPlugins, |
There was a problem hiding this comment.
perhaps:
pageLoadAssetSize: {
external: externalPlugins,
internal: osdPlugins,
}
Since both categories are technically OpenSearch Dashboards Plugins
| existingLimit != null && existingLimit >= metric.value | ||
| ? existingLimit | ||
| : metric.value + DEFAULT_BUDGET; | ||
|
|
||
| if (metric.id.includes('Dashboards')) { |
There was a problem hiding this comment.
Unfortunately I don't think we can use Dashboards I can see that some internal plugins got caught in this filter for example opensearchDashboardsReact.
There was a problem hiding this comment.
I think we could filter out results that include "Dashboards" but specifically exclude those that start with "opensearchDashboards"
| @@ -93,22 +93,37 @@ export function validateLimitsForAllBundles(log: ToolingLog, config: OptimizerCo | |||
| export function updateBundleLimits(log: ToolingLog, config: OptimizerConfig) { | |||
| const metrics = getMetrics(log, config); | |||
There was a problem hiding this comment.
will need to update validate function as well
|
Hi @ananzh, is this PR for 2.15 or 2.16? |
Description
This commit updates the
updateBundleLimitsfunction to categorize plugin limits into 'External Plugins' and 'OpenSearch Dashboards Plugins'. Each category is now sorted by size in descending order. This categorization and sorting are aimed atimproving the clarity and manageability of the page load asset size limits.
Issues Resolved
NA
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration