Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] Duplicate selected/all saved objects #6478

Open
wants to merge 35 commits into
base: main
Choose a base branch
from

Conversation

yubonluo
Copy link
Contributor

@yubonluo yubonluo commented Apr 16, 2024

Description

This PR follows up #6288 which can be used to duplicate saved objects among workspaces.
Only UI change in this PR.

Issues Resolved

#6388

Screenshot

screenshot-508.mov

There are three types of duplicate buttons on the saved objects management page.
image

If the user clicks the duplicate button, a modal window will pop up as follows:
image

Changelog

  • feat: [Workspace] Duplicate selected/all saved objects

Testing the changes

  1. Clone the latest code and run yarn osd bootstrap
  2. Modify config/opensearch_dashboards.yml, add workspace.enabled: true
  3. Run yarn start --no-base-path
  4. Create a workspace and create some saved objects like index patterns, visualizations, etc.
  5. Call the copy api following the above usage.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 91.50943% with 9 lines in your changes missing coverage. Please review.

Project coverage is 67.47%. Comparing base (14af23a) to head (b618076).

Files Patch % Lines
...ment_section/objects_table/saved_objects_table.tsx 87.03% 3 Missing and 4 partials ⚠️
...ction/objects_table/components/duplicate_modal.tsx 96.00% 0 Missing and 1 partial ⚠️
...agement_section/objects_table/components/table.tsx 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6478      +/-   ##
==========================================
+ Coverage   67.44%   67.47%   +0.03%     
==========================================
  Files        3442     3446       +4     
  Lines       67816    67924     +108     
  Branches    11027    11043      +16     
==========================================
+ Hits        45740    45835      +95     
- Misses      19409    19420      +11     
- Partials     2667     2669       +2     
Flag Coverage Δ
Linux_1 32.61% <5.76%> (-0.48%) ⬇️
Linux_2 55.11% <ø> (ø)
Linux_3 45.19% <ø> (ø)
Linux_4 35.01% <91.00%> (+0.14%) ⬆️
Windows_1 32.63% <5.76%> (-0.48%) ⬇️
Windows_2 55.06% <ø> (ø)
Windows_3 45.21% <ø> (ø)
Windows_4 35.01% <91.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yubonluo and others added 2 commits April 19, 2024 15:53
Signed-off-by: yubonluo <yubonluo@amazon.com>
@lauralexis
Copy link

Hey @yubonluo, thanks for opening. I'm not able to see the videos.

Do you have some screen shots? Also just confirming with @opensearch-project/opensearch-ux the expected workflow.

@yubonluo I’d like to make some adjustments to the workflow you shared earlier. I’m putting my recommendation together.

@yubonluo
Copy link
Contributor Author

Hey @yubonluo, thanks for opening. I'm not able to see the videos.

Do you have some screen shots? Also just confirming with @opensearch-project/opensearch-ux the expected workflow.

The screen shots has been added.

Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
@yubonluo
Copy link
Contributor Author

yubonluo commented Jun 4, 2024

CC @SuZhou-Joe @ruanyl could you please help me review this pr?

Signed-off-by: yubonluo <yubonluo@amazon.com>
@BionIT
Copy link
Collaborator

BionIT commented Jun 5, 2024

Hi @yubonluo , are we targeting this PR for 2.15 or 2.16?

@yubonluo
Copy link
Contributor Author

yubonluo commented Jun 5, 2024

Hi @yubonluo , are we targeting this PR for 2.15 or 2.16?

Hi @BionIT due to waiting for the final confirmation of the UI text, this PR will be released on 2.16.

@BionIT BionIT added the v2.16.0 label Jun 5, 2024
Signed-off-by: yubonluo <yubonluo@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants