-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace] Duplicate selected/all saved objects #6478
base: main
Are you sure you want to change the base?
Conversation
27cb3dd
to
bbf4cb1
Compare
Signed-off-by: yubonluo <yubonluo@amazon.com>
bbf4cb1
to
41d33da
Compare
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6478 +/- ##
==========================================
+ Coverage 67.44% 67.47% +0.03%
==========================================
Files 3442 3446 +4
Lines 67816 67924 +108
Branches 11027 11043 +16
==========================================
+ Hits 45740 45835 +95
- Misses 19409 19420 +11
- Partials 2667 2669 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: yubonluo <yubonluo@amazon.com>
@yubonluo I’d like to make some adjustments to the workflow you shared earlier. I’m putting my recommendation together. |
The screen shots has been added. |
…oards into main-dupluicate
…oards into main-dupluicate
Signed-off-by: yubonluo <yubonluo@amazon.com>
…boards into main-dupluicate
Signed-off-by: yubonluo <yubonluo@amazon.com>
src/plugins/saved_objects_management/public/lib/duplicate_saved_objects.ts
Outdated
Show resolved
Hide resolved
src/plugins/saved_objects_management/public/lib/duplicate_saved_objects.test.ts
Outdated
Show resolved
Hide resolved
...ed_objects_management/public/management_section/objects_table/components/duplicate_modal.tsx
Outdated
Show resolved
Hide resolved
...ins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx
Outdated
Show resolved
Hide resolved
...ins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx
Outdated
Show resolved
Hide resolved
...ins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx
Outdated
Show resolved
Hide resolved
...ins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx
Show resolved
Hide resolved
...ins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx
Outdated
Show resolved
Hide resolved
src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: yubonluo <yubonluo@amazon.com>
…oards into main-dupluicate
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
CC @SuZhou-Joe @ruanyl could you please help me review this pr? |
Signed-off-by: yubonluo <yubonluo@amazon.com>
…oards into main-dupluicate
Hi @yubonluo , are we targeting this PR for 2.15 or 2.16? |
Signed-off-by: yubonluo <yubonluo@amazon.com>
…oards into main-dupluicate
Description
This PR follows up #6288 which can be used to duplicate saved objects among workspaces.
Only UI change in this PR.
Issues Resolved
#6388
Screenshot
screenshot-508.mov
There are three types of duplicate buttons on the saved objects management page.
If the user clicks the duplicate button, a modal window will pop up as follows:
Changelog
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration