Allow the flipping of the primary mouse button

[geoff-harper]

Hey I've finally had some time to go through and give this a swing. I decided to treat it the same as the click threshold values on the Mousetracker class since that made the most sense to me. Let me know if there are any convention things you'd like me to change.

There's the question of what to do with the context menu. Currently when you flip nothing is done about it so it opens after every pan. I wasn't sure if this is something we're concerned with or if it should be resolved in userland

As an aside, I went down a bit of a rabbit hole with isPrimary and getIsPrimary to eventually discover they don't really do anything. I've left them alone since there's a good chance I'm misinterpreting what they're for.

[iangilman]

Thank you for getting this rolling! For reference, this is where this feature was discussed:

#2224

I'm still feeling like we would be better off adding a panWithSecondaryButton flag, as I think that future-proofs the API better. I'm particularly concerned about flipping the meaning of primary and secondary at the MouseTracker level, as that seems like it could lead to all sorts of confusion. I think the primary and secondary buttons should always be solid, and it's what they do that should be customizable.

Does that make sense?

[geoff-harper]

Yeah I get that. Amusingly once I pulled the fork into my own project I realized all my canvas-clicks were now on right button too and I hated it. I can try to change it to flipping pan only.

To follow up, part of my issue personally is that canvas-drag isn't fired by the secondary button. Would changing this or adding a canvas-nonprimary-drag be appropriate? Unfortunately I can't just use the pan event since I specifically need pans that were triggered by user interaction, and not pans that were triggered programatically by myself

[iangilman]

Good point! Yes, please add a canvas-nonprimary-drag; that seems like the right solution to me.

[iangilman]

@geoff-harper Happy new year! Are you still interested in working on this patch?

[geoff-harper]

Hey apologies I've been away. Yes I'd like to get this working but I haven't had the time lately and I'll be fairly busy through January. If someone else wanted to take it from here that would be fine since I don't want to hold up a release or anything, but I will come back and finish it otherwise

[iangilman]

@geoff-harper Okay, great to know! We'll see if anyone else picks it up. Otherwise, see you in February :)

[msalsbery]

@geoff-harper @iangilman

I'm looking into taking this - see comment here

[msalsbery]

@geoff-harper I'll take this on if you're cool with that. If so, can I just take over your branch or should I make a new one?

cc @iangilman

[geoff-harper]

Sure @msalsbery, sorry I got caught up in other things and I'm currently away for a month or so. Let me know what you need

[msalsbery]

Sure @msalsbery, sorry I got caught up in other things and I'm currently away for a month or so. Let me know what you need

Cool, thank you - no problem. I'll work from your pr/2258 branch (I think...I'll post here if I start from a fresh branch)

The handling of alternate buttons by MouseTracker hasn't really changed since way back pre-v2 so I need to go through and bring it up-to-date with the W3C Pointer Events model so it's a bit more involved than just using the existing events ;)