Changed console logs to error or info (not a lot) #1925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linked to this issue, but I don't know how to link issues. |
|
@athammana If you could please resolve the merge conflicts we can get this landed :) |
iangilman
requested changes
Mar 15, 2021
| @@ -2294,7 +2294,25 @@ function OpenSeadragon( options ){ | |||
|
|
|||
| request.send(null); | |||
| } catch (e) { | |||
| $.console.log( "%s while making AJAX request: %s", e.name, e.message ); | |||
| var msg = e.message; | |||
There was a problem hiding this comment.
I believe all of this IE code has been removed on master, so I think it's being mistakenly added back here (due to a merge conflict). Would you agree, @msalsbery ?
I think this whole section simply needs to become :
$.console.error( "%s while making AJAX request: %s", e.name, e.message );
@athammana can you make that change?
There was a problem hiding this comment.
@iangilman Yeah weird it doesn't show conflict, but master should definitely be merged into athammana:master ...there's code right below there that's now gone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This is my first ever issue so let me know if I did anything wrong or messed anything up! Also there were a couple of console logs I left in navigator.js module for tests because they were behind a debug flag.