Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to flip over the x or y axis #1847

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cbeer
Copy link
Contributor

@cbeer cbeer commented Jul 2, 2020

We'd like the ability to flip the viewer across the x-axis (the use case is.. something about scholars studying piano rolls and, I gather, a lack of conventions about which way is "up") .

In this PR, I extended the viewport flipped property from a structure that allows you to flip across each axis independently. I tried to address some backwards compatibility concerns, but perhaps a separate property for each axis would be preferable?

If this feature is desirable (and I get some guidance on an approach) I'm happy to update any tests, docs, etc.

Thanks.

@iangilman
Copy link
Member

Thank you for making this PR! Apologies for the slow response... Things have been a little crazy lately.

The approach seems reasonable (though I'd love to hear what @nelsonn3c thinks). You've even done some to address the backwards compatibility issue (though perhaps more will be necessary).

One basic question to start with, though: If you combine the current flip with a 180 degree rotation, that's the same as a vertical flip. Is that an acceptable solution, or do we need the addition of the vertical flip to achieve something specific?

Even if it's not entirely necessary, it does seem like it might be a more pleasant UI. Anyway, just trying to understand the situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants