Add the ability to flip over the x or y axis #1847
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd like the ability to flip the viewer across the x-axis (the use case is.. something about scholars studying piano rolls and, I gather, a lack of conventions about which way is "up") .
In this PR, I extended the viewport
flipped
property from a structure that allows you to flip across each axis independently. I tried to address some backwards compatibility concerns, but perhaps a separate property for each axis would be preferable?If this feature is desirable (and I get some guidance on an approach) I'm happy to update any tests, docs, etc.
Thanks.