Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IIIF tile sources to include grayscale. #1838

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ionab
Copy link

@ionab ionab commented Jun 10, 2020

Add option for IIIF grayscale images as per the specification in https://iiif.io/api/image/2.0/#quality

Add option for IIIF grayscale images as per the specification in https://iiif.io/api/image/2.0/#quality
@ionab ionab marked this pull request as draft June 10, 2020 11:50
@ionab ionab marked this pull request as ready for review June 10, 2020 16:45
Copy link
Member

@iangilman iangilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good feature to add! Thank you for getting this rolling.

It's an IIIF-only feature, though, so it should just be in the IIIFTileSource, not the more general parts of the code. Can you please make that change?

@@ -393,6 +393,9 @@ $.extend( $.IIIFTileSource.prototype, $.TileSource.prototype, /** @lends OpenSea
iiifTileSizeHeight = Math.ceil( tileHeight / scale );
if (this.version === 1) {
iiifQuality = "native." + this.tileFormat;
}
else if (this.tileQuality) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put the else if on the same line as the closing curly bracket, to match our code style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants