-
-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change how internal console messages are written #1886
Comments
Good point! Someone should go through and audit which things should be what level. We already have a number of console.error, console.warn, and console.assert that should stay as is. Probably anything that's console.log should either become console.error (where it's an error message), console.info (if it's still worthwhile information), or removed/commented out (if it's entirely unnecessary). You're welcome to make a pull request to that effect if you'd like. If not, hopefully someone else will pick this up. |
Hi @iangilman, I am new to open source. I would like to start by contributing to this issue. Can you help me understand it completely or any guidance on how I can solve this would be really great and helpful. |
@Abhishek-90 welcome! This is a wonderful issue to work on :) My recommendation is to search the Don't change any of the logging in the If you need info about making a pull request, check out https://github.com/openseadragon/openseadragon/wiki/Making-a-Pull-Request Thank you! |
@iangilman thankyou very much. I will get to it now. |
Hi @iangilman , I want to contribute to issue can you help me further |
@bonysureliya Great! It looks like this issue is actually fixed (by #2073), so I'll close it. There are a number of other issues you can start with: Just pick one and get started! Let me know if you have questions. Here's more info on contributing: https://github.com/openseadragon/openseadragon/blob/master/CONTRIBUTING.md |
Please change your console messages to info or debug instead of log so they can be disabled easily. Playing "spot the actually useful log I wrote for myself" in a sea of Openseadragon spam isn't a fun dev experience. Of course I could filter them every time I open the dev tools but why? It also spams remote analytics tools which requires extra filtering etc.
The text was updated successfully, but these errors were encountered: