Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(framework): fix breaking changes with terraform plugin framework v0.11.1 #85

Conversation

iacabezasbaculima
Copy link
Contributor

@iacabezasbaculima iacabezasbaculima commented Aug 20, 2022

Closes #84
Relates #81
Relates hashicorp/terraform-plugin-framework#432
Relates hashicorp/terraform-plugin-framework#434

TF_ACC=1 go test -v -cover -timeout 120m ./... -run TestAccJira
?   	github.com/openscientia/terraform-provider-atlassian	[no test files]
?   	github.com/openscientia/terraform-provider-atlassian/internal/generate/issuelabels	[no test files]
?   	github.com/openscientia/terraform-provider-atlassian/internal/generate/prlabels	[no test files]
?   	github.com/openscientia/terraform-provider-atlassian/internal/generate/repolabels	[no test files]
=== RUN   TestAccJiraIssueFieldConfigurationDataSource_Basic
=== PAUSE TestAccJiraIssueFieldConfigurationDataSource_Basic
=== RUN   TestAccJiraIssueScreen_DataSource_Basic
--- PASS: TestAccJiraIssueScreen_DataSource_Basic (1.74s)
=== RUN   TestAccJiraIssueScreen_DataSource_ErrorCases
--- PASS: TestAccJiraIssueScreen_DataSource_ErrorCases (0.12s)
=== RUN   TestAccJiraIssueTypeSchemeDataSource
--- PASS: TestAccJiraIssueTypeSchemeDataSource (1.95s)
=== RUN   TestAccJiraIssueTypeScreenSchemeDataSource_Basic
=== PAUSE TestAccJiraIssueTypeScreenSchemeDataSource_Basic
=== RUN   TestAccJiraIssueTypeDataSource
--- PASS: TestAccJiraIssueTypeDataSource (1.32s)
=== RUN   TestAccJiraScreenSchemeDataSource_Basic
=== PAUSE TestAccJiraScreenSchemeDataSource_Basic
=== RUN   TestAccJiraIssueFieldConfigurationItem_Basic
=== PAUSE TestAccJiraIssueFieldConfigurationItem_Basic
=== RUN   TestAccJiraIssueFieldConfigurationItem_Description
=== PAUSE TestAccJiraIssueFieldConfigurationItem_Description
=== RUN   TestAccJiraIssueFieldConfigurationItem_IsHidden
=== PAUSE TestAccJiraIssueFieldConfigurationItem_IsHidden
=== RUN   TestAccJiraIssueFieldConfigurationItem_IsRequired
=== PAUSE TestAccJiraIssueFieldConfigurationItem_IsRequired
=== RUN   TestAccJiraIssueFieldConfigurationItem_Renderer
=== PAUSE TestAccJiraIssueFieldConfigurationItem_Renderer
=== RUN   TestAccJiraIssueFieldConfigurationItem_RendererErrors
=== PAUSE TestAccJiraIssueFieldConfigurationItem_RendererErrors
=== RUN   TestAccJiraIssueFieldConfigurationItem_NonRenderableErrors
=== PAUSE TestAccJiraIssueFieldConfigurationItem_NonRenderableErrors
=== RUN   TestAccJiraIssueFieldConfigurationItem_LockedErrors
=== PAUSE TestAccJiraIssueFieldConfigurationItem_LockedErrors
=== RUN   TestAccJiraIssueFieldConfigurationItem_HiddenRequired
=== PAUSE TestAccJiraIssueFieldConfigurationItem_HiddenRequired
=== RUN   TestAccJiraIssueFieldConfigurationItem_ForceNewResource
=== PAUSE TestAccJiraIssueFieldConfigurationItem_ForceNewResource
=== RUN   TestAccJiraIssueFieldConfigurationScheme_Basic
=== PAUSE TestAccJiraIssueFieldConfigurationScheme_Basic
=== RUN   TestAccJiraIssueFieldConfigurationScheme_Description
=== PAUSE TestAccJiraIssueFieldConfigurationScheme_Description
=== RUN   TestAccJiraIssueFieldConfiguration_Basic
=== PAUSE TestAccJiraIssueFieldConfiguration_Basic
=== RUN   TestAccJiraIssueFieldConfiguration_Name
=== PAUSE TestAccJiraIssueFieldConfiguration_Name
=== RUN   TestAccJiraIssueFieldConfiguration_Description
=== PAUSE TestAccJiraIssueFieldConfiguration_Description
=== RUN   TestAccJiraIssueScreen
--- PASS: TestAccJiraIssueScreen (2.06s)
=== RUN   TestAccJiraIssueTypeSchemeResource
--- PASS: TestAccJiraIssueTypeSchemeResource (3.93s)
=== RUN   TestAccJiraIssueTypeScreenScheme_Basic
=== PAUSE TestAccJiraIssueTypeScreenScheme_Basic
=== RUN   TestAccJiraIssueTypeScreenScheme_Description
=== PAUSE TestAccJiraIssueTypeScreenScheme_Description
=== RUN   TestAccJiraIssueTypeScreenScheme_DefaultMapping
=== PAUSE TestAccJiraIssueTypeScreenScheme_DefaultMapping
=== RUN   TestAccJiraIssueTypeScreenScheme_IssueTypeMappings
=== PAUSE TestAccJiraIssueTypeScreenScheme_IssueTypeMappings
=== RUN   TestAccJiraIssueTypeResource
--- PASS: TestAccJiraIssueTypeResource (2.54s)
=== RUN   TestAccJiraScreenScheme_Basic
=== PAUSE TestAccJiraScreenScheme_Basic
=== RUN   TestAccJiraScreenScheme_Description
=== PAUSE TestAccJiraScreenScheme_Description
=== RUN   TestAccJiraScreenScheme_Screens
=== PAUSE TestAccJiraScreenScheme_Screens
=== CONT  TestAccJiraIssueFieldConfigurationDataSource_Basic
=== CONT  TestAccJiraIssueFieldConfigurationScheme_Basic
=== CONT  TestAccJiraIssueFieldConfigurationItem_Renderer
=== CONT  TestAccJiraIssueFieldConfigurationItem_ForceNewResource
=== CONT  TestAccJiraIssueFieldConfigurationItem_IsRequired
=== CONT  TestAccJiraIssueFieldConfigurationItem_HiddenRequired
=== CONT  TestAccJiraIssueFieldConfigurationItem_NonRenderableErrors
=== CONT  TestAccJiraIssueFieldConfigurationItem_IsHidden
=== CONT  TestAccJiraIssueFieldConfigurationItem_LockedErrors
=== CONT  TestAccJiraIssueTypeScreenScheme_Description
=== CONT  TestAccJiraIssueFieldConfigurationItem_RendererErrors
--- PASS: TestAccJiraIssueFieldConfigurationScheme_Basic (1.65s)
--- PASS: TestAccJiraIssueFieldConfigurationItem_RendererErrors (0.13s)
=== CONT  TestAccJiraIssueFieldConfigurationItem_Description
=== CONT  TestAccJiraIssueTypeScreenSchemeDataSource_Basic
--- PASS: TestAccJiraIssueTypeScreenScheme_Description (2.82s)
--- PASS: TestAccJiraIssueFieldConfigurationItem_LockedErrors (3.07s)
=== CONT  TestAccJiraScreenSchemeDataSource_Basic
--- PASS: TestAccJiraIssueFieldConfigurationItem_HiddenRequired (3.60s)
=== CONT  TestAccJiraIssueFieldConfigurationItem_Basic
--- PASS: TestAccJiraIssueFieldConfigurationItem_ForceNewResource (3.64s)
=== CONT  TestAccJiraIssueFieldConfiguration_Name
--- PASS: TestAccJiraIssueFieldConfigurationItem_NonRenderableErrors (3.84s)
=== CONT  TestAccJiraIssueTypeScreenScheme_Basic
--- PASS: TestAccJiraIssueFieldConfigurationItem_Renderer (4.16s)
=== CONT  TestAccJiraScreenScheme_Basic
--- PASS: TestAccJiraScreenSchemeDataSource_Basic (1.84s)
=== CONT  TestAccJiraIssueFieldConfiguration_Description
--- PASS: TestAccJiraIssueFieldConfigurationDataSource_Basic (5.14s)
=== CONT  TestAccJiraScreenScheme_Screens
--- PASS: TestAccJiraIssueFieldConfigurationItem_Description (3.37s)
=== CONT  TestAccJiraScreenScheme_Description
--- PASS: TestAccJiraIssueTypeScreenSchemeDataSource_Basic (2.56s)
=== CONT  TestAccJiraIssueFieldConfiguration_Basic
--- PASS: TestAccJiraScreenScheme_Basic (1.53s)
=== CONT  TestAccJiraIssueFieldConfigurationScheme_Description
--- PASS: TestAccJiraIssueFieldConfiguration_Name (2.22s)
=== CONT  TestAccJiraIssueTypeScreenScheme_IssueTypeMappings
=== CONT  TestAccJiraIssueTypeScreenScheme_DefaultMapping
--- PASS: TestAccJiraIssueFieldConfigurationItem_Basic (2.36s)
--- PASS: TestAccJiraIssueTypeScreenScheme_Basic (2.23s)
--- PASS: TestAccJiraIssueFieldConfiguration_Basic (1.68s)
--- PASS: TestAccJiraIssueFieldConfiguration_Description (2.17s)
--- PASS: TestAccJiraScreenScheme_Screens (2.34s)
--- PASS: TestAccJiraScreenScheme_Description (2.33s)
--- PASS: TestAccJiraIssueFieldConfigurationScheme_Description (2.39s)
--- PASS: TestAccJiraIssueTypeScreenScheme_IssueTypeMappings (2.79s)
--- PASS: TestAccJiraIssueTypeScreenScheme_DefaultMapping (2.99s)
--- PASS: TestAccJiraIssueFieldConfigurationItem_IsRequired (9.53s)
--- PASS: TestAccJiraIssueFieldConfigurationItem_IsHidden (15.95s)
PASS
coverage: 67.9% of statements
ok  	github.com/openscientia/terraform-provider-atlassian/internal/provider	29.803s	coverage: 67.9% of statements
?   	github.com/openscientia/terraform-provider-atlassian/internal/provider/attribute_plan_modification	[no test files]
?   	github.com/openscientia/terraform-provider-atlassian/internal/provider/attribute_validation	[no test files]

@iacabezasbaculima iacabezasbaculima linked an issue Aug 20, 2022 that may be closed by this pull request
1 task
@iacabezasbaculima iacabezasbaculima self-assigned this Aug 20, 2022
@github-actions github-actions bot added jira/issuefieldconfigurations Issues and PRs that pertain to jira/issuefieldconfigurations resources. jira/issuefieldconfigurationitems Issues and PRs that pertain to jira/issuefieldconfigurationitems resources. jira/issuefieldconfigurationschemes Issues and PRs that pertain to jira/issuefieldconfigurationschemes resources. jira/issuetypescreenschemes Issues and PRs that pertain to jira/issuetypescreenschemes resources. jira/issuetypeschemes Issues and PRs that pertain to jira/issuetypeschemes resources. jira/issuetypes Issues and PRs that pertain to jira/issuetypes resources. jira/screenschemes Issues and PRs that pertain to jira/screenschemes resources. provider Pertains to the provider itself, rather than any interaction with AWS. labels Aug 20, 2022
@iacabezasbaculima iacabezasbaculima modified the milestone: v0.2.0 Aug 20, 2022
@iacabezasbaculima iacabezasbaculima merged commit a51ffce into main Aug 20, 2022
@iacabezasbaculima iacabezasbaculima deleted the 84-fix-breaking-changes-with-terraform-plugin-framework-v0111 branch August 28, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/issuefieldconfigurationitems Issues and PRs that pertain to jira/issuefieldconfigurationitems resources. jira/issuefieldconfigurations Issues and PRs that pertain to jira/issuefieldconfigurations resources. jira/issuefieldconfigurationschemes Issues and PRs that pertain to jira/issuefieldconfigurationschemes resources. jira/issuetypes Issues and PRs that pertain to jira/issuetypes resources. jira/issuetypeschemes Issues and PRs that pertain to jira/issuetypeschemes resources. jira/issuetypescreenschemes Issues and PRs that pertain to jira/issuetypescreenschemes resources. jira/screenschemes Issues and PRs that pertain to jira/screenschemes resources. provider Pertains to the provider itself, rather than any interaction with AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix breaking changes with Terraform Plugin Framework v0.11.1
1 participant