New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new page about federation #829
Conversation
Your Render PR Server URL is https://opensafely-documentation-pr-829.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cath0lvh8vlfhb4appjg. |
A deploy for your Render PR Server at https://opensafely-documentation-pr-829.onrender.com just failed. View details on your dashboard at https://dashboard.render.com/static/srv-cath0lvh8vlfhb4appjg. |
84a6a00
to
6ea2716
Compare
Your Render PR Server at https://opensafely-documentation-pr-829.onrender.com is now live! View it on your dashboard at https://dashboard.render.com/static/srv-cath0lvh8vlfhb4appjg. |
6fef021
to
74ed3c5
Compare
Your Render PR Server at https://opensafely-documentation-pr-829.onrender.com is now live! View it on your dashboard at https://dashboard.render.com/static/srv-cath0lvh8vlfhb4appjg. |
1 similar comment
Your Render PR Server at https://opensafely-documentation-pr-829.onrender.com is now live! View it on your dashboard at https://dashboard.render.com/static/srv-cath0lvh8vlfhb4appjg. |
0a3e7d1
to
6cfa071
Compare
Your Render PR Server at https://opensafely-documentation-pr-829.onrender.com is now live! View it on your dashboard at https://dashboard.render.com/static/srv-cath0lvh8vlfhb4appjg. |
1 similar comment
Your Render PR Server at https://opensafely-documentation-pr-829.onrender.com is now live! View it on your dashboard at https://dashboard.render.com/static/srv-cath0lvh8vlfhb4appjg. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, for what that's worth!
|
||
One problem OpenSAFELY solves is that backends may present very different environments and databases: for example, TPP provides their data in a _Microsoft SQL Server_ database on a hardware server, and EMIS provides it via their _EXA_ analytic platform in the cloud. OpenSAFELY tools hide these differences from researchers, so that their code can be run **everywhere**. After code is run on a backend, its outcomes are carefully checked for safety within the same secure perimeter, and finally released so that they can be **recombined**: | ||
|
||
```mermaid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: It's nice that you've used the built-in diagram support 👍
There might be others elsewhere in the docs that we can replace.
This does make a request to unpkg.com
to retrieve the JavaScript which gives me two thoughts:
- Might this be blocked for users if they are on a work IT network?
- Are there privacy issues we care about? (Perhaps not: we already use Google Fonts.)
It is possible to host the JavaScript ourselves although we then need to manually keep it in sync.
I'm undecided, but worth a thought.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noticed an unpleasant FOUC type effect with mermaid; I wonder if hosting the javascript ourselves would solve this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about the privacy plugin as a solution? I'm quite keen to pay for mkdocs given how much use we've made of it, anyway
.pre-commit-config.yaml
Outdated
@@ -1,5 +1,5 @@ | |||
default_language_version: | |||
python: python3.10 | |||
python: python3.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment: I don't think this should change.
It's applied to the databuilder/
directory and I think this does want to use newer Python.
In the worst case, you can commit via git commit --no-verify
, but maybe we need to look into this again. It's the mess of dealing with multiple Python versions in the same repository, unfortunately.
I did have a look at solving this in #832, but didn't get round to tidying that up yet. It's once again another issue that it would solve.
I've added a couple of small comments for polish ✨ and I don't think the But no issues with the actual written content which looks good 👍 |
Your Render PR Server at https://opensafely-documentation-pr-829.onrender.com is now live! View it on your dashboard at https://dashboard.render.com/static/srv-cath0lvh8vlfhb4appjg. |
Also sync precommit version with .python-version, so I can commit it
8c4d548
to
1398781
Compare
Your Render PR Server at https://opensafely-documentation-pr-829.onrender.com is now live! View it on your dashboard at https://dashboard.render.com/static/srv-cath0lvh8vlfhb4appjg. |
Also sync precommit version with .python-version, so I can commit it