Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #1930

Merged
merged 4 commits into from
Feb 28, 2024
Merged

Update dependencies #1930

merged 4 commits into from
Feb 28, 2024

Commits on Feb 27, 2024

  1. fix: Upgrade production dependencies 

    Dependabot still isn't doing this for us (see #964).
    @evansd
    evansd committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    3bbe9a4 View commit details
    Browse the repository at this point in the history

  2. Upgrade development dependencies 

    Dependabot _does_ do this for us, but we may as well do this while we're
hear and save fiddling around with a bunch of individual PRs.
    @evansd
    evansd committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    7dbf060 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary workaround 

    This was added in #1885 and can be removed now that the upstream patch
has been released.
    @evansd
    evansd committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    62a76d1 View commit details
    Browse the repository at this point in the history

  4. Disable statement caching for SQLite dialect 

    This doesn't benefit us at all (it's designed to avoid the compilation
overhead when executing the same SQL over and over) and it leads to
warnings when we execute clause elements whose caching behaviour has not
be explicitly defined.

We're getting a warning here now because we've just updated to Trino
v0.328.0 which includes this PR:
 * trinodb/trino-python-client#429

This defines a compiler for the `Lag` clause which (because it is not
restricted to a specific dialect) ends up being used by SQLite and
triggering the warning.
    @evansd
    evansd committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    58b8561 View commit details
    Browse the repository at this point in the history