Partial support for parsing XML namespaces #3925
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove duplicate NonNull; see package-info.java Validate argument not literal Apply formatter
|
Thanks for getting this started @ammachado ! I've also tagged @knutwannheden for review since we're adding methods in the |
timtebeek
reviewed
Jan 16, 2024
rewrite-xml/src/main/java/org/openrewrite/xml/internal/XmlNamespaceUtils.java
Outdated
Show resolved
Hide resolved
|
Once merged we can revisit these recipes in rewrite-migrate-java: |
# Conflicts: # rewrite-xml/src/test/java/org/openrewrite/xml/ChangeNamespaceValueTest.java
rewrite-xml/src/main/java/org/openrewrite/xml/ChangeNamespaceValue.java
Outdated
Show resolved
Hide resolved
| if (this.root == root) { | ||
| return this; | ||
| } | ||
| Map<String, String> namespaces = XmlNamespaceUtils.extractNamespaces(root.getAttributes()); |
There was a problem hiding this comment.
What is the purpose of extracting the namespaces here?
There was a problem hiding this comment.
Would we need this back in to later support namespace lookup for particular elements?
For example, using the test file, and wanting to look for the XPath /client/conduitSelector with the http://cxf.apache.org/jaxws namespace:
<jaxws:client name="{http://cxf.apache.org/hello_world_soap_http}SoapPort" createdFromAPI="true" xmlns:jaxws="http://cxf.apache.org/jaxws">
<jaxws:conduitSelector>
<bean class="org.apache.cxf.endpoint.DeferredConduitSelector"/>
</jaxws:conduitSelector>
</jaxws:client>
…alue.java Co-authored-by: Knut Wannheden <knut.wannheden@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Partial support for #3919, including namespace parsing and resolution
What's your motivation?
#3919
Anything in particular you'd like reviewers to focus on?
No
Anyone you would like to review specifically?
No
Have you considered any alternatives or workarounds?
No
Any additional context
No
Checklist