Add refaster recipes to simplify expected value #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copied from rewrite-recipe-starter
timo-abele
force-pushed
the
simple-refaster-recipes
branch
from
328ac47
to
2fdafa0
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/test/java/org/openrewrite/java/testing/assertj/SimplifyAssertExpectationsTest.java
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/testing/assertj/SimplifyAssertExpectationsTest.java
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/testing/assertj/SimplifyAssertExpectationsTest.java
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/testing/assertj/SimplifyAssertExpectationsTest.java
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
| public class SimplifyToIsZero { | ||
|
|
||
| @BeforeTemplate | ||
| void before(Integer i) { |
There was a problem hiding this comment.
I think you want to use primitive types in the method signatures.
There was a problem hiding this comment.
I tried it for both "Integer" recipes, but still get "Recipe was expected to make a change but made no changes." for all three tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
3 simple refaster recipes added
What's your motivation?
salvaging the changes in #472
adding missing transformations I noticed.
Anything in particular you'd like reviewers to focus on?
These recipes are simpler that the ones in #472: they don't need generics and should work in Java 8. But each test yields:
Anyone you would like to review specifically?
@timtebeek
Have you considered any alternatives or workarounds?
SimplifyChainedAssertJAssertion could probably be extended to cover these cases, but I think refaster is the appropriate level of complexity
Any additional context
Checklist