added recipe to collapse consecutive AssertThat statements (#373) #392
Conversation
|
Really nice to see you picked this up @srmalkan! Impressed with how much of the recipe already works. I've explored locally if I could get the indentation to work, but no such luck yet either. I'd expected the fix to be in setting a prefix on each of the method invocations where we change the select, but I've not yet found a working combination. Will try to explore later again. |
|
Yes, i thought so too. After looking at few objects, now i feel its related to setting up 'after' correctly in JRightPadded. |
|
Hi @timtebeek, I was able to fix formatting by setting |
|
Glad to see how far this has come! I think we can just adjust the |
That's correct. |
| int statementListSize = statements.size(); | ||
| List<J.MethodInvocation> currList = new ArrayList<>(); | ||
| for (int currIndex = 0; currIndex < statementListSize; currIndex++) { |
There was a problem hiding this comment.
| int statementListSize = statements.size(); | |
| List<J.MethodInvocation> currList = new ArrayList<>(); | |
| for (int currIndex = 0; currIndex < statementListSize; currIndex++) { | |
| List<J.MethodInvocation> currList = new ArrayList<>(); | |
| for (int currIndex = 0; currIndex < statements.size(); currIndex++) { |
| Optional<J.MethodInvocation> assertThatMi = getAssertThatMi(statement); | ||
| if (assertThatMi.isPresent()) { | ||
| if (isAssertThatValid(statement)) { | ||
| if (!getFirstArgumentName(assertThatMi.get()).equals(prevArg)) { |
There was a problem hiding this comment.
Does it make sense to use org.openrewrite.java.search.SemanticallyEqual here instead of just checking the argument name?
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
...t/java/org/openrewrite/java/testing/assertj/CollapseConsecutiveAssertThatStatementsTest.java
Show resolved
Hide resolved
...t/java/org/openrewrite/java/testing/assertj/CollapseConsecutiveAssertThatStatementsTest.java
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
src/main/java/org/openrewrite/java/testing/assertj/CollapseConsecutiveAssertThatStatements.java
Outdated
Show resolved
Hide resolved
…secutiveAssertThatStatements.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
src/main/java/org/openrewrite/java/testing/assertj/CollapseConsecutiveAssertThatStatements.java
Outdated
Show resolved
Hide resolved
Closes #373
Hi All,
I have added a recipe to collapse if consecutive AssertThat statements on the same parameter are found. It ignores cases where the parameter is a Method Invocation or lambda or existing chained assertThat statement.
I am facing a bit of difficulty in formatting the chained assertThat statement, can someone guide me on that?